diff mbox series

testsuite/98002 - fix gcc.dg/strncmp-2.c

Message ID nycvar.YFH.7.76.2011261008490.28212@elmra.sevgm.obk
State New
Headers show
Series testsuite/98002 - fix gcc.dg/strncmp-2.c | expand

Commit Message

Richard Biener Nov. 26, 2020, 9:09 a.m. UTC 
This makes sure not to free() memory we have mprotected to PROT_NONE
by calling mprotect again with PROT_READ|PROT_WRITE.  This avoids
crashing the allocator when in debug mode.

Tested on x86_64-unknown-linux-gnu.

OK?

2020-11-16  Richard Biener  <rguenther@suse.de>

	PR testsuite/98002
	* gcc.dg/strncmp-2.c: Call mprotect again before free.
---
 gcc/testsuite/gcc.dg/strncmp-2.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jakub Jelinek Nov. 26, 2020, 9:10 a.m. UTC | #1 
On Thu, Nov 26, 2020 at 10:09:11AM +0100, Richard Biener wrote:
> This makes sure not to free() memory we have mprotected to PROT_NONE
> by calling mprotect again with PROT_READ|PROT_WRITE.  This avoids
> crashing the allocator when in debug mode.
> 
> Tested on x86_64-unknown-linux-gnu.
> 
> OK?
> 
> 2020-11-16  Richard Biener  <rguenther@suse.de>
> 
> 	PR testsuite/98002
> 	* gcc.dg/strncmp-2.c: Call mprotect again before free.

Yes, thanks.

	Jakub
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/strncmp-2.c b/gcc/testsuite/gcc.dg/strncmp-2.c
index 6818b304b36..0d84f932767 100644
--- a/gcc/testsuite/gcc.dg/strncmp-2.c
+++ b/gcc/testsuite/gcc.dg/strncmp-2.c
@@ -40,6 +40,7 @@  static void test_driver_strncmp (void (test_strncmp)(const char *, const char *,
     e = lib_memcmp(buf1,p2,sz);
     (*test_memcmp)(buf1,p2,e);
   }
+  mprotect (buf2+pgsz,pgsz,PROT_READ|PROT_WRITE);
   free(buf2);
 }