From patchwork Wed Apr 25 04:41:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 154791 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5EFFBB6FA3 for ; Wed, 25 Apr 2012 14:41:41 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1335933702; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=qvRjIZwXSzr5RMucehrRdfOLftM=; b=wdsChXi8rMn9y1i K9BmIVSDocNhvbZO9litx3A4ADYJoFnTzB/wgJwngo0Ha5FQ3/IeceROXjRa/ldl dn0ineH2bKlURsePk3MJ8xazsAFbNbshs86AxvJp4xhpK/qyXE1wvjZejCkJIzUF laYT1QqDAScGDXIb0xpsaiqOPNcQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=ysJ2+cfOBFkFI5B9Rb4ePT6ZVPkR/gQD35dd6vVJmLmxR/7y6HY6HckGjbbyQ4 WXXXgZ7fjnM7Z9FC2HShkGxSV6TJwrR1GVd5OHdrQT+hLB0qero4XwdZt7oWULFK KutHLxFglQvR+hnoi4prGzwY7eHibrykHP8ZKnkB2rcsk=; Received: (qmail 14333 invoked by alias); 25 Apr 2012 04:41:36 -0000 Received: (qmail 14321 invoked by uid 22791); 25 Apr 2012 04:41:34 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mail-pb0-f47.google.com (HELO mail-pb0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Apr 2012 04:41:21 +0000 Received: by pbcum15 with SMTP id um15so910945pbc.20 for ; Tue, 24 Apr 2012 21:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type:x-gm-message-state; bh=1lDxKUlmGhLgUZ61/yPI3rX8tC/v+Dh7mCgyUhpTAck=; b=n9Dw41qyiXZT5uuhWfAB8y2L3ezjZ9iaiUn1g9B3PCeCd9BVjVdzqFwxoObAfxmjrW MfZOk8od0iCcGhqgwuaE6uT2XYqRzO6/5RpPmmNtrFq/cdn+2HLBdscjhAGZvpYto9Bh rUeV5k1zogqY/ZM2vX+qhsB9Tc6lDNl1JM9Nc/bk1Lepev8TdotWpdGm5F17MG2mNxVt cs2a/nlP+zVVOoD7659a98naivPUurMcMlPr78YIyliM8Yr0wcIHAo5GVapzKZyMqYpd 6BRYTF3/Jl8WORHb7T/TPM/yQTon7F8k4BdF+ZwUJu6UxAL8/hxy1DCpDYpLpUGiz1cA eSgg== Received: by 10.68.229.97 with SMTP id sp1mr4447770pbc.41.1335328881155; Tue, 24 Apr 2012 21:41:21 -0700 (PDT) Received: by 10.68.229.97 with SMTP id sp1mr4447743pbc.41.1335328880956; Tue, 24 Apr 2012 21:41:20 -0700 (PDT) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id rp17sm9644859pbb.20.2012.04.24.21.41.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Apr 2012 21:41:20 -0700 (PDT) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: libgo patch committed: Fix crypto/rand test to read all data Date: Tue, 24 Apr 2012 21:41:19 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQncqgAppw6cTpig6C1ebLMZaLqrDnr0nnUJyPyeOa/bxAZ5wdlL81mzhups4nduZTaTMqmPRMj6upaLzINBZJX6yrzLcxae+Km3E2UXwrVwKFpOujlgD1IhrExl39JZZD6aeonZ8h+GyBd/FKfEtpPVMKgcuDtoVtCcCtGfk9weMKSZZAE= X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch to libgo fixes the crypto/rand test to read all the data that it needs. This should fix PR 52341. Bootstrapped and ran crypto/rand test on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian diff -r c4931780d05a libgo/go/crypto/rand/rand_test.go --- a/libgo/go/crypto/rand/rand_test.go Tue Apr 24 21:24:41 2012 -0700 +++ b/libgo/go/crypto/rand/rand_test.go Tue Apr 24 21:38:23 2012 -0700 @@ -7,6 +7,7 @@ import ( "bytes" "compress/flate" + "io" "testing" ) @@ -16,9 +17,9 @@ n = 1e5 } b := make([]byte, n) - n, err := Read(b) + n, err := io.ReadFull(Reader, b) if n != len(b) || err != nil { - t.Fatalf("Read(buf) = %d, %s", n, err) + t.Fatalf("ReadFull(buf) = %d, %s", n, err) } var z bytes.Buffer