From patchwork Sat Mar 26 05:45:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 88452 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 31CC11007D2 for ; Sat, 26 Mar 2011 16:45:34 +1100 (EST) Received: (qmail 6045 invoked by alias); 26 Mar 2011 05:45:30 -0000 Received: (qmail 6033 invoked by uid 22791); 26 Mar 2011 05:45:29 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Mar 2011 05:45:24 +0000 Received: from kpbe14.cbf.corp.google.com (kpbe14.cbf.corp.google.com [172.25.105.78]) by smtp-out.google.com with ESMTP id p2Q5jMtE031653 for ; Fri, 25 Mar 2011 22:45:22 -0700 Received: from pxi16 (pxi16.prod.google.com [10.243.27.16]) by kpbe14.cbf.corp.google.com with ESMTP id p2Q5jKA6000311 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Fri, 25 Mar 2011 22:45:21 -0700 Received: by pxi16 with SMTP id 16so292719pxi.32 for ; Fri, 25 Mar 2011 22:45:20 -0700 (PDT) Received: by 10.142.238.17 with SMTP id l17mr1399457wfh.99.1301118320222; Fri, 25 Mar 2011 22:45:20 -0700 (PDT) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id d35sm2321478wfj.9.2011.03.25.22.45.18 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Mar 2011 22:45:19 -0700 (PDT) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Go patch committed: better error setting const to nil Date: Fri, 25 Mar 2011 22:45:17 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch to the Go frontend gives a better error message when setting a const to nil. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d04de877d993 go/gogo.cc --- a/go/gogo.cc Fri Mar 25 22:31:14 2011 -0700 +++ b/go/gogo.cc Fri Mar 25 22:41:02 2011 -0700 @@ -1527,7 +1527,9 @@ && !ctype->is_boolean_type() && !ctype->is_string_type()) { - if (!ctype->is_error()) + if (ctype->is_nil_type()) + error_at(constant->location(), "const initializer cannot be nil"); + else if (!ctype->is_error()) error_at(constant->location(), "invalid constant type"); constant->set_error(); }