From patchwork Sat Nov 17 00:52:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 199809 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E39752C008C for ; Sat, 17 Nov 2012 11:52:39 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353718361; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=uohaOVe qHA2Y0Z75XbYCSbv3nM8=; b=TANewTxMa/9RWCCFsIfXwOO79GcgkzBhDDARqEK KiwlNvc8gogJi8O3qRaf0GgH3hMwW3jPTeg7Xbp7xHbYx8AieyP+1DgVJWNuz4Ud gftv8dgYvBP6xsDzUleURXl3EDNyeJ1jjrxjx36+UkNjxqy2GU/yOr8mEF+T40UJ FiKE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=CGA1mZsyEAO0PKs/HbBU3/2T6NeOzG9oNLWEG9j/HLNnwLz6cN7kFcujswuwds Vt0Htior/RNXX3CtsZE7IAUsyY9+J7DRrQEtmrgEMCpbZBiOtLBsdCFwWEvtR7NE SQrQoj/cOpeSly7kA/rtQAHXLxoSwmYsw5kWxYXjQHHP8=; Received: (qmail 7396 invoked by alias); 17 Nov 2012 00:52:33 -0000 Received: (qmail 7386 invoked by uid 22791); 17 Nov 2012 00:52:32 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mail-da0-f47.google.com (HELO mail-da0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Nov 2012 00:52:27 +0000 Received: by mail-da0-f47.google.com with SMTP id s35so1297170dak.20 for ; Fri, 16 Nov 2012 16:52:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type:x-gm-message-state; bh=W1jO2mMMC4ozQcAr2hafAV4jOyV2vf3A8N4QDrHaedE=; b=LoMLznSWB5vJs4FQUC9CsSuJLxXFH48APUxHXsiRZyLLk5tE9o9JW30ncxDMAilI1/ N66dSpizCaSzwAltnpnbkYJyqQm1ePpq/4ZYcOxhYIvz1yqmXMzyOisO8wBu1bGRm1Pf YAc6QrnjzdLdCdu91hx5aQ6EC3t8gGbyA2T/TYO6xW6ra8dF2bkzdICJFywA+S1IVfep c/tTejyq1NrobVqpSMHE3o3jnXPZgqdqgBaXRI9DjqJxVaouOGqUJlRfzORcWKl7cInb ATDcL3KdKBVnIyEVhdFcfHpbPIYk6CtWvt/oSGsjpuUp27X5qkGksRs00IzHtQg1IAP+ CECA== Received: by 10.68.233.197 with SMTP id ty5mr20506104pbc.9.1353113546899; Fri, 16 Nov 2012 16:52:26 -0800 (PST) Received: from coign.google.com ([207.198.105.20]) by mx.google.com with ESMTPS id us7sm2009944pbc.40.2012.11.16.16.52.26 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 16 Nov 2012 16:52:26 -0800 (PST) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org Subject: libgo patch committed: Fix use of __atomic_compare_exchange_n Date: Fri, 16 Nov 2012 16:52:24 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlc0i6CDuWAEg4vi8HNsupQNa9cnnvLWmcAjZq8K6R/fm9lJMTRB51kHAK7J7blJCPEdhWOsR/OaO1cPG80S4RbdBegdaKmDBJolrUyHVGlVeX3WmqciupK1He9vNmF1kXLdhm794V9X1jvfXfs/kD8SIBtNgwsERlsynhyRF9HEIceDO+fEbC1Kcp7Lq1/1b/z+62Lo1xDUupOQXypqBpwd9L0aw== X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Based on advice from Dmitry Vyukov, this patch fixes the use of __atomic_compare_exchange_n in libgo. The Go library assumes a strong compare-exchange operation, and always assumes sequential consistency around the operation. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu, where, as it happens, this patch makes no different anyhow. Committed to mainline. Ian diff -r db71d396d9e5 libgo/runtime/runtime.h --- a/libgo/runtime/runtime.h Fri Nov 16 08:03:04 2012 -0800 +++ b/libgo/runtime/runtime.h Fri Nov 16 16:43:50 2012 -0800 @@ -518,7 +518,7 @@ void free(void *v); #define runtime_cas(pval, old, new) __sync_bool_compare_and_swap (pval, old, new) #define runtime_casp(pval, old, new) __sync_bool_compare_and_swap (pval, old, new) -#define runtime_cas64(pval, pold, new) __atomic_compare_exchange_n (pval, pold, new, 1, __ATOMIC_SEQ_CST, __ATOMIC_RELAXED) +#define runtime_cas64(pval, pold, new) __atomic_compare_exchange_n (pval, pold, new, 0, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) #define runtime_xadd(p, v) __sync_add_and_fetch (p, v) #define runtime_xadd64(p, v) __sync_add_and_fetch (p, v) #define runtime_xchg(p, v) __atomic_exchange_n (p, v, __ATOMIC_SEQ_CST)