From patchwork Sun Feb 12 05:57:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 140799 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D5606B6EEC for ; Sun, 12 Feb 2012 16:57:26 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1329631051; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=Saq5wv7tSH/k5l9vHwSaCPuT23A=; b=r5CtNzy1OgEyLaK E7Y+K372orWN1bJbPKB5Q9jwjeKjO4vA2HLNMhjIs+oA75Z+eHwlhceeuq5QQ+4P 9XickVLq7D8qgydPDfPujkd2L5dVcsgKA0oD/X7TLjr1U5D9KIwpGgxrZnXGJJIH 1Q10gkGRn4Rsq0vuhr/nR2ZT3bQY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=JsX/TvSHj9fMjvX0HFZanonN760dNXlMXVMtnaz/hLPhkz7alPWRjqowasSlQz I/MxY1trcQ3do676Qgst9PpeHXBlNMmOTva7OcVQfwj3KRICtokVTiSf9fbwgHIR S0Ki80Acrzc2RvAtKDWV/4nm2eB5SMKssr7r5ZPDbJSP0=; Received: (qmail 25663 invoked by alias); 12 Feb 2012 05:57:20 -0000 Received: (qmail 25654 invoked by uid 22791); 12 Feb 2012 05:57:19 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mail-pw0-f47.google.com (HELO mail-pw0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Feb 2012 05:57:07 +0000 Received: by pbcum15 with SMTP id um15so3308338pbc.20 for ; Sat, 11 Feb 2012 21:57:06 -0800 (PST) Received: by 10.68.224.9 with SMTP id qy9mr33636716pbc.102.1329026226553; Sat, 11 Feb 2012 21:57:06 -0800 (PST) Received: by 10.68.224.9 with SMTP id qy9mr33636701pbc.102.1329026226445; Sat, 11 Feb 2012 21:57:06 -0800 (PST) Received: from coign.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net. [71.133.8.30]) by mx.google.com with ESMTPS id b4sm25703416pbc.7.2012.02.11.21.57.05 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 11 Feb 2012 21:57:05 -0800 (PST) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: libgo patch committed: Disable inappropriate sync/atomic tests Date: Sat, 11 Feb 2012 21:57:05 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQna2MmoPrtVv4SNhtVFSP6CZbkhd6fko9o0FUpSUDYAzMDYe03EEXjuLniFAEUTz5qf94umqomfafW4rxNeXQ3NlYzRfD7OVHspkq6ebLKJoDOpryTJ470V6cdC1QtxVJKkltrN+IeGWedFKAlnHfgpLMV9LTCpsuS6+x998MPqhtXAUlU= X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch to the sync/atomic package disables a couple of tests on systems with an inappropriate pointer size. The 32-bit test was clobbering 4 bytes on the heap. The 64-bit test only worked on little-endian systems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d75f0efa5fc2 libgo/go/sync/atomic/atomic_test.go --- a/libgo/go/sync/atomic/atomic_test.go Fri Feb 10 23:04:22 2012 -0800 +++ b/libgo/go/sync/atomic/atomic_test.go Sat Feb 11 21:54:35 2012 -0800 @@ -636,6 +636,7 @@ // 64-bit system; clear uintptr tests hammer32[2].f = nil hammer32[5].f = nil + hammer32[6].f = nil } } @@ -760,6 +761,7 @@ // 32-bit system; clear uintptr tests hammer64[2].f = nil hammer64[5].f = nil + hammer64[6].f = nil } }