From patchwork Mon Oct 31 21:55:25 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 122970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D08CDB6F69 for ; Tue, 1 Nov 2011 08:55:49 +1100 (EST) Received: (qmail 26800 invoked by alias); 31 Oct 2011 21:55:47 -0000 Received: (qmail 26792 invoked by uid 22791); 31 Oct 2011 21:55:46 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Oct 2011 21:55:33 +0000 Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7]) by smtp-out.google.com with ESMTP id p9VLtTpe021331 for ; Mon, 31 Oct 2011 14:55:29 -0700 Received: from pzk36 (pzk36.prod.google.com [10.243.19.164]) by hpaq7.eem.corp.google.com with ESMTP id p9VL42fC015010 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 31 Oct 2011 14:55:28 -0700 Received: by pzk36 with SMTP id 36so27488840pzk.3 for ; Mon, 31 Oct 2011 14:55:27 -0700 (PDT) Received: by 10.68.199.41 with SMTP id jh9mr25695625pbc.60.1320098127829; Mon, 31 Oct 2011 14:55:27 -0700 (PDT) Received: by 10.68.199.41 with SMTP id jh9mr25695600pbc.60.1320098127648; Mon, 31 Oct 2011 14:55:27 -0700 (PDT) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id 3sm53570902pbx.14.2011.10.31.14.55.26 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 31 Oct 2011 14:55:27 -0700 (PDT) From: Ian Lance Taylor To: Rainer Orth Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: Go patch committed: Implement new syscall package References: Date: Mon, 31 Oct 2011 14:55:25 -0700 In-Reply-To: (Rainer Orth's message of "Fri, 28 Oct 2011 18:59:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Rainer Orth writes: > /vol/gcc/src/hg/trunk/local/libgo/go/syscall/errstr_nor.go:22:8: error: referenc > e to undefined name 'libc_strerror' > make[4]: *** [syscall/syscall.lo] Error 1 Sorry about that. I thought I had tested that, but evidently not. Fixed like so. Committed to mainline. Ian diff -r 56a1bd1d907a libgo/go/syscall/errstr_nor.go --- a/libgo/go/syscall/errstr_nor.go Mon Oct 31 14:41:55 2011 -0700 +++ b/libgo/go/syscall/errstr_nor.go Mon Oct 31 14:53:22 2011 -0700 @@ -11,7 +11,7 @@ "unsafe" ) -//sysnb strerror(errnum int) *byte +//sysnb strerror(errnum int) (buf *byte) //strerror(errnum int) *byte var errstr_lock sync.Mutex @@ -19,7 +19,7 @@ func Errstr(errno int) string { errstr_lock.Lock() - bp := libc_strerror(errno) + bp := strerror(errno) b := (*[1000]byte)(unsafe.Pointer(bp)) i := 0 for b[i] != 0 {