From patchwork Mon Aug 3 16:34:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1340372 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=idmk2cOL; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BL3Pr3JTfz9sTX for ; Tue, 4 Aug 2020 02:34:38 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E8113861878; Mon, 3 Aug 2020 16:34:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E8113861878 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1596472476; bh=Wed35pOOdIr4Uckc/bV8cZC1cxLIuzdpeGn98BIM5c8=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=idmk2cOL8ZvieLgE28GWLQk1xwKryqx8R8/NAqcj1rYnqAL//o5P2u/CHZSL7vyQ1 ukNnSu+eqkAJQjwbwpj6cvp3phxzoTLG6WhK8bRbJ/V9v9xoiQXUu0f3TShfa3vDt3 Wry09kL4niBMoQ7xw5Hm05y+OVqL97Mcu0pfph2I= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 1EFD33857C52 for ; Mon, 3 Aug 2020 16:34:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1EFD33857C52 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-SDarfQwZN-KUlxxcJEq0yA-1; Mon, 03 Aug 2020 12:34:31 -0400 X-MC-Unique: SDarfQwZN-KUlxxcJEq0yA-1 Received: by mail-wr1-f71.google.com with SMTP id f7so11837109wrs.8 for ; Mon, 03 Aug 2020 09:34:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=Wed35pOOdIr4Uckc/bV8cZC1cxLIuzdpeGn98BIM5c8=; b=W3cBDttxpznwAHykrkk2f0FwOKGSeOnD+qch+OsHzITh2Ux/gwgewqVqjllcqG5QmY qSQuS5PGGuWp5aVheT0Rw8mPNmLNw2sGcHFt+JpGmmfEwKVyFytGO7CFL8LcbnINrK19 pWb9e5FmbR1LXYdtTFNp4liQXouxv6Ydx+IkrfFUp9rLbw6/obVtwWM2PeCDGdFypPaX qyZ2YDylmfXXsLiNhNVQLx4ThLXrHz8J5MJfohY7SGvOSyoqIGd5eEXEstzivyedYPmN iFgBj/bxHj/TTlK1rAMuKmI6dGjEVuuwtfS/ZGynuOs1g5L4pDrARSZRgA2wRjcpKLAe rOmg== X-Gm-Message-State: AOAM533Wo5bQrDNWBaJ9LB5s2KAstwWLBwqqVNFJGI/Ryk88XRCE5z5R Uz4NE7CbFr63p93q0Tm9+XU2OId713EpFkzVRhH9Qfd1CkCDMBQFTHwanjxYbkeJStzY0GWiMTe dqO7V0FS/UF58j3TnSA== X-Received: by 2002:adf:f64a:: with SMTP id x10mr14862211wrp.99.1596472470542; Mon, 03 Aug 2020 09:34:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylgDPzmKemqwzlskkBjstW8wesw3z/aasllVzZVqHvFHvbo+irixnFT64Nmq+ytriN6Dhmyw== X-Received: by 2002:adf:f64a:: with SMTP id x10mr14862196wrp.99.1596472470217; Mon, 03 Aug 2020 09:34:30 -0700 (PDT) Received: from abulafia.quesejoda.com ([95.169.235.146]) by smtp.gmail.com with ESMTPSA id s131sm183473wme.17.2020.08.03.09.34.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2020 09:34:29 -0700 (PDT) To: gcc-patches Subject: [pushed] PR tree-optimization/96430: Avoid shifting by amounts larger than target int in irange self-tests. Message-ID: Date: Mon, 3 Aug 2020 18:34:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Fixes PR. Pushed. commit 6c4763fa5b55f6e883ed7077b67c6175c2da63d1 Author: Aldy Hernandez Date: Mon Aug 3 18:30:30 2020 +0200 Avoid shifting by amounts larger than target int in irange self-tests. gcc/ChangeLog: PR tree-optimization/96430 * range-op.cc (operator_tests): Do not shift by 31 on targets with integer's smaller than 32 bits. diff --git a/gcc/range-op.cc b/gcc/range-op.cc index c62e3977ce5..b7b708b488b 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -3527,15 +3527,16 @@ operator_tests () } // signed: ~[-1] = OP1 >> 31 - { - widest_irange lhs (INT (-1), INT (-1), VR_ANTI_RANGE); - widest_irange shift (INT (31), INT (31)); - widest_irange op1; - op_rshift.op1_range (op1, integer_type_node, lhs, shift); - widest_irange negatives = range_negatives (integer_type_node); - negatives.intersect (op1); - ASSERT_TRUE (negatives.undefined_p ()); - } + if (TYPE_PRECISION (integer_type_node) > 31) + { + widest_irange lhs (INT (-1), INT (-1), VR_ANTI_RANGE); + widest_irange shift (INT (31), INT (31)); + widest_irange op1; + op_rshift.op1_range (op1, integer_type_node, lhs, shift); + widest_irange negatives = range_negatives (integer_type_node); + negatives.intersect (op1); + ASSERT_TRUE (negatives.undefined_p ()); + } } // Run all of the selftests within this file.