From patchwork Fri Aug 31 17:58:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 181001 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4E3F12C0369 for ; Sat, 1 Sep 2012 03:59:17 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1347040758; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:Date:To:Subject:User-Agent:MIME-Version: Content-Type:Content-Transfer-Encoding:Message-ID:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=gIj8dKtmgm3NuBLCMs4lw5u15zs=; b=sgLFXE48Ig0Brl9fashMOZ+Swrbv/0VUjTIvt/yurqBiOTULf/av8ycoEJKFnh fxxkX0Vi14H5EM3E04Hv7zjsJqobfNCTrfD20HiQLJm/tREEwDHOkenIVSeWsmDT 9+siBA9saOkV1DJBrYZh5gBY1ikAk7JFwjBMkgwejEcCI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-M-MSG:Received:Received:Received:From:Date:To:Subject:User-Agent:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID:X-EMS-Proccessed:X-EMS-STAMP:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Fv/ZRQ+yRNsYXOuAiZLs73qHUM9fjgTMQoH2/dTyIE/coperL5cVQdXyIZ068d u7vw9WpAO9x4l8r+c6mNzIY0VAzIczHafSr2zYFv7B1FRduZgr4jFq4VvAjCw8qD mgjeAkpTX8KbTomwtAURHL2F5NmCNdpda/5ZhfzSsDhC8=; Received: (qmail 28120 invoked by alias); 31 Aug 2012 17:59:10 -0000 Received: (qmail 28108 invoked by uid 22791); 31 Aug 2012 17:59:08 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from dns1.mips.com (HELO dns1.mips.com) (12.201.5.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Aug 2012 17:58:56 +0000 Received: from mailgate1.mips.com (mailgate1.mips.com [12.201.5.111]) by dns1.mips.com (8.13.8/8.13.8) with ESMTP id q7VHwtRr012845 for ; Fri, 31 Aug 2012 10:58:55 -0700 X-M-MSG: Received: from exchdb01.mips.com (unknown [192.168.36.84]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mailgate1.mips.com (Postfix) with ESMTP id 25D1936463C for ; Fri, 31 Aug 2012 10:58:54 -0700 (PDT) Received: from ubuntu-sellcey.mips.com (192.168.65.53) by exchhub01.mips.com (192.168.36.84) with Microsoft SMTP Server id 14.1.270.1; Fri, 31 Aug 2012 10:58:51 -0700 Received: by ubuntu-sellcey.mips.com (sSMTP sendmail emulation); Fri, 31 Aug 2012 10:58:51 -0700 From: "Steve Ellcey " Date: Fri, 31 Aug 2012 10:58:51 -0700 To: Subject: [Patch, PR 54128] ira.c change to fix mips bootstrap User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Message-ID: X-EMS-Proccessed: 6LP3oGfGVdcdb8o1aBnt6w== X-EMS-STAMP: jMZ/8ZTHDmIO7zaIqNdnZg== Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Here is my patch to fix the bootstrap comparision failure (PR 54128) on MIPS. The reason for the comparision failure was a difference in register usage and I tracked it down to build_insn_chain which checked all instructions for register usage in order to set the dead_or_set and live_relevant_regs bitmaps instead of checking only non-debug instructions. Changing INSN_P to NONDEBUG_INSN_P in build_insn_chain allowed me to bootstrap and caused no regressions. OK to checkin? Steve Ellcey sellcey@mips.com 2012-08-31 Steve Ellcey PR bootstrap/54128 * ira.c (build_insn_chain): Check only NONDEBUG instructions for register usage. diff --git a/gcc/ira.c b/gcc/ira.c index 3825498..477c87b 100644 --- a/gcc/ira.c +++ b/gcc/ira.c @@ -3341,7 +3341,7 @@ build_insn_chain (void) c->insn = insn; c->block = bb->index; - if (INSN_P (insn)) + if (NONDEBUG_INSN_P (insn)) for (def_rec = DF_INSN_UID_DEFS (uid); *def_rec; def_rec++) { df_ref def = *def_rec; @@ -3432,7 +3432,7 @@ build_insn_chain (void) bitmap_and_compl_into (live_relevant_regs, elim_regset); bitmap_copy (&c->live_throughout, live_relevant_regs); - if (INSN_P (insn)) + if (NONDEBUG_INSN_P (insn)) for (use_rec = DF_INSN_UID_USES (uid); *use_rec; use_rec++) { df_ref use = *use_rec;