| Message ID | f962cb68-2f4f-b295-6950-73916cd5a3bc@embecosm.com |
|---|---|
| State | New |
| Headers | show |
| Series | RISC-V: Fix regular expression in target-specific test | expand |
On Fri, Jul 10, 2020 at 6:53 AM Simon Cook <simon.cook@embecosm.com> wrote: > Some square brackets were missing escape characters, causing DejaGnu to > try and call a proc with the name "at". > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/read-thread-pointer.c: Fix escaping on > regular expression. Thanks. Committed. I noticed that the riscv-gnu-toolchain "make report" command doesn't check for or report dejagnu errors, which is maybe how Kito missed this. Jim
Hi Simon: Thanks for your fix! Hi Jim: Yeah, I think I should check the dejagnu errors. On Sat, Jul 11, 2020 at 12:46 PM Jim Wilson <jimw@sifive.com> wrote: > > On Fri, Jul 10, 2020 at 6:53 AM Simon Cook <simon.cook@embecosm.com> wrote: > > Some square brackets were missing escape characters, causing DejaGnu to > > try and call a proc with the name "at". > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/read-thread-pointer.c: Fix escaping on > > regular expression. > > Thanks. Committed. > > I noticed that the riscv-gnu-toolchain "make report" command doesn't > check for or report dejagnu errors, which is maybe how Kito missed > this. > > Jim
diff --git a/gcc/testsuite/gcc.target/riscv/read-thread-pointer.c b/gcc/testsuite/gcc.target/riscv/read-thread-pointer.c index 760f8eafb40..401fb421129 100644 --- a/gcc/testsuite/gcc.target/riscv/read-thread-pointer.c +++ b/gcc/testsuite/gcc.target/riscv/read-thread-pointer.c @@ -4,4 +4,4 @@ void *get_tp() { return __builtin_thread_pointer (); } -/* { dg-final { scan-assembler "mv\[ \t\]*[at][0-9]+,tp" } } */ +/* { dg-final { scan-assembler "mv\[ \t\]*\[at\]\[0-9\]+,tp" } } */
Some square brackets were missing escape characters, causing DejaGnu to try and call a proc with the name "at". gcc/testsuite/ChangeLog: * gcc.target/riscv/read-thread-pointer.c: Fix escaping on regular expression. --- gcc/testsuite/gcc.target/riscv/read-thread-pointer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1