From patchwork Tue Jul 23 21:49:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pchang9@cs.wisc.edu X-Patchwork-Id: 261224 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B90492C009C for ; Wed, 24 Jul 2013 07:49:54 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:subject:from:to:mime-version:content-type; q= dns; s=default; b=EkaljcXCcX1hk0skNOa/dlS3+r+CAsxc7942w19gbJ/VEm g219aoMGNw7bQR5wAShkFSksA3P17u3KdUD9WWQd4L/EzHWTLzY1s0fTSkmvX2IW 8u8FE4wdgUn97jMCZY8Xvrr/SbHdFoqCEaHHiqDzTb4YBbRsGBgtn8YKRBGQM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:subject:from:to:mime-version:content-type; s= default; bh=UVJ+U9VAUNgYBloP9h5HwmD/nYo=; b=gM4EmVHr5US9BR0lPRX3 kWWFcXQMo+qdNeLBW/extMa+zOIWYdgLk4MoFY+Kh+jb75qMfiHL/hYcazDszXP1 GZUL06+plUvU666MORHZ3mdXAyxFNW/GccJioHPIhOu2MytPoNT2caxs3m1rwmAb 31s28YTuwo/MRWcG+rntwlA= Received: (qmail 14195 invoked by alias); 23 Jul 2013 21:49:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 14177 invoked by uid 89); 23 Jul 2013 21:49:42 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_HOSTKARMA_W, RDNS_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from Unknown (HELO sandstone.cs.wisc.edu) (128.105.6.39) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Jul 2013 21:49:41 +0000 Received: from webmail.cs.wisc.edu (george.cs.wisc.edu [128.105.7.110]) by sandstone.cs.wisc.edu (8.14.1/8.14.1) with ESMTP id r6NLnXqA021892; Tue, 23 Jul 2013 16:49:33 -0500 Received: from 146.151.118.255 (SquirrelMail authenticated user pchang9) by webmail.cs.wisc.edu with HTTP; Tue, 23 Jul 2013 16:49:33 -0500 Message-ID: Date: Tue, 23 Jul 2013 16:49:33 -0500 Subject: [Patch, PR 57802] Wasted work in set_loop_bounds() From: pchang9@cs.wisc.edu To: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 X-Virus-Found: No Hi, The problem appears in revision 201034 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57802 Bootstrap and regression-tested on x86_64-linux. In method "set_loop_bounds()" in gcc/fortran/trans-array.c, the loop on line 4456 should break immediately after "nonoptional_arr" is set to "true". 2013-07-23 Chang * trans-array.c (set_loop_bounds): Exit loop after setting nonoptional_arr. -Chang Index: gcc/fortran/trans-array.c =================================================================== --- gcc/fortran/trans-array.c (revision 201034) +++ gcc/fortran/trans-array.c (working copy) @@ -4456,7 +4456,10 @@ for (ss = loop->ss; ss != gfc_ss_terminator; ss = ss->loop_chain) if (ss->info->type != GFC_SS_SCALAR && ss->info->type != GFC_SS_TEMP && ss->info->type != GFC_SS_REFERENCE && !ss->info->can_be_null_ref) - nonoptional_arr = true; + { + nonoptional_arr = true; + break; + } /* We use one SS term, and use that to determine the bounds of the loop for this dimension. We try to pick the simplest term. */ Index: gcc/fortran/trans-array.c =================================================================== --- gcc/fortran/trans-array.c (revision 201034) +++ gcc/fortran/trans-array.c (working copy) @@ -4456,7 +4456,10 @@ for (ss = loop->ss; ss != gfc_ss_terminator; ss = ss->loop_chain) if (ss->info->type != GFC_SS_SCALAR && ss->info->type != GFC_SS_TEMP && ss->info->type != GFC_SS_REFERENCE && !ss->info->can_be_null_ref) - nonoptional_arr = true; + { + nonoptional_arr = true; + break; + } /* We use one SS term, and use that to determine the bounds of the loop for this dimension. We try to pick the simplest term. */