From patchwork Wed Apr 12 08:35:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Segher Boessenkool X-Patchwork-Id: 749818 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w2y276k4Yz9sNQ for ; Wed, 12 Apr 2017 18:36:30 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="UWVwfsbu"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; q=dns; s=default; b=vJ3UVBOTxVDB Ebqq3o9u2hP945/AXZ57WM53k35ol7Ifq4tOEZZATkq/41z9oA1Op33chKYlGis0 ziBUh/p3qHhOUawBvoHcIAq8X/zCvku30QmjAV+yeehi0NTjw5Ym8UeeRqsjGOAN S8iPKc0YQfKzj/crpPu3mSXhqFJarcE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; s=default; bh=7K0ZixNPYor3UfO0Gv v1Vf3Wf2Q=; b=UWVwfsbuyW4ToRombsD1sTb3DQfUQJJntWher7YfOYKGA5ea9p R45agCCx4mUh+fnPl4e3aooVxopo/a6/jbx3MfiJCz7818s+hiVrN3m/sCCZMgef FVSyeiT9VzXKfq5Bj0HZcOUs8auJLQeFQmmtG4SDLkje3pae3AD3GIztk= Received: (qmail 118453 invoked by alias); 12 Apr 2017 08:35:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 118337 invoked by uid 89); 12 Apr 2017 08:35:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=stq, Hx-languages-length:1509 X-HELO: gcc1-power7.osuosl.org Received: from gcc1-power7.osuosl.org (HELO gcc1-power7.osuosl.org) (140.211.15.137) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 08:35:50 +0000 Received: by gcc1-power7.osuosl.org (Postfix, from userid 10019) id 41DF21C067B; Wed, 12 Apr 2017 08:35:48 +0000 (UTC) From: Segher Boessenkool To: gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, bergner@vnet.ibm.com, Segher Boessenkool Subject: [PATCH] rs6000: Enforce quad_address_p in TImode atomic_load/store (PR80382) Date: Wed, 12 Apr 2017 08:35:42 +0000 Message-Id: X-IsSubscribed: yes Whatever expand expands to should be valid instructions. The defined instructions here have a quad_memory_operand predicate, which boils down to quad_address_p on the address, so let's test for that instead of only disallowing indexed addresses. Tested on powerpc64-linux, applying to trunk. Segher 2017-04-12 Segher Boessenkool * config/rs6000/sync.md (atomic_load, atomic_store" rtx op1 = operands[1]; rtx pti_reg = gen_reg_rtx (PTImode); - // Can't have indexed address for 'lq' - if (indexed_address (XEXP (op1, 0), TImode)) + if (!quad_address_p (XEXP (op1, 0), TImode, false)) { rtx old_addr = XEXP (op1, 0); rtx new_addr = force_reg (Pmode, old_addr); @@ -231,8 +230,7 @@ (define_expand "atomic_store" rtx op1 = operands[1]; rtx pti_reg = gen_reg_rtx (PTImode); - // Can't have indexed address for 'stq' - if (indexed_address (XEXP (op0, 0), TImode)) + if (!quad_address_p (XEXP (op0, 0), TImode, false)) { rtx old_addr = XEXP (op0, 0); rtx new_addr = force_reg (Pmode, old_addr);