From patchwork Mon Jan 30 09:43:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aurelien Buhrig X-Patchwork-Id: 721291 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vBkxq3318z9sXx for ; Mon, 30 Jan 2017 20:44:28 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="qHzm8MfV"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type; q=dns; s= default; b=AAt8tkWMX8I0MGmOtE407seD00g3HtHwMVHCgtx9VRsQnwXxkeI8j G8LKOgo+MKz3Z5ty4MEaZblkpDtAn4YpfB3qjU4e2CLBcRzPlzOJ1e4cJnvfEHo1 rfTecBI8yRLCh3viiN01Msuk6e7pNEkrQl4mtBWGIleF1Xj5Mg7SRI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type; s= default; bh=GmmsmCakWZjpVkzY+crnLS8AoqQ=; b=qHzm8MfVEWudY1XQJASJ oVGKBIhcyhc+mIyV4e/dy20O3gakuPGCCHfEjT0c5qO7EHGlpsPk8EJr2ipoN+ye uLQmme97WHiAe6tcBpthBYcrHLfjcSNfJEqTCi5T5lygRS41NZHBF9nrA6+YlMxi 1K3aNiDm7tFRcR8cclF0jM8= Received: (qmail 116810 invoked by alias); 30 Jan 2017 09:44:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 116678 invoked by uid 89); 30 Jan 2017 09:44:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wj0-f195.google.com Received: from mail-wj0-f195.google.com (HELO mail-wj0-f195.google.com) (209.85.210.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jan 2017 09:44:09 +0000 Received: by mail-wj0-f195.google.com with SMTP id i7so6983787wjf.2 for ; Mon, 30 Jan 2017 01:44:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version; bh=5VR8zY7jhL0DydWOomAxv83WAp0LpXXbHcBWEJBtkEA=; b=gCTBKmAFr4irHiY8sj3kNBxWZMXzan4b323i3LcWnRa6krNr7P4W1MpdU+KV7yRXQO N+VwPB1JPeddy+ZLwOZISmWey4D9vqErMWGisi5T2zedksF++MslFAD43WRxY2Mddv/U JtnE3esQTG+ImK9w8fkL/iV+3SOuAapId/ZZvo+zPHCnez8F1YGkiCAkFq26F7b4Tcf1 9icxMSzp78FKardj1vLVdy/eV3TQuZZsszUWch1mZf5Q/FDF6E7ppn6lzuXtJ9doU/4N Yej1r0WSPBUvgCZWhg+/YGjEW+Hj6RNvkd1dWY47Xd5/yK9+U2AKRBkcjhGtP9Veiogx EFmg== X-Gm-Message-State: AIkVDXJfnnGBi2ZEVdgE0BuC67TDlLKVDbCB+/ddJ5SPFesaZKbdXC8WzB0J1BHPolESMw== X-Received: by 10.223.164.10 with SMTP id d10mr16905947wra.90.1485769446678; Mon, 30 Jan 2017 01:44:06 -0800 (PST) Received: from [10.15.38.164] ([92.103.127.250]) by smtp.gmail.com with ESMTPSA id q5sm21949815wrd.32.2017.01.30.01.44.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 01:44:05 -0800 (PST) From: Aurelien Buhrig Subject: [patch 79279] combine/simplify_set issue To: gcc-patches@gcc.gnu.org Message-ID: Date: Mon, 30 Jan 2017 10:43:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Hi, This patch fixes a combiner bug in simplify_set which calls CANNOT_CHANGE_MODE_CLASS with wrong mode params. It occurs when trying to simplify paradoxical subregs of hw regs (whose natural mode is lower than a word). In fact, changing from (set x:m1 (subreg:m1 (op:m2))) to (set (subreg:m2 x) op2) is valid if REG_CANNOT_CHANGE_MODE_P (x, m1, m2) is false and REG_CANNOT_CHANGE_MODE_P (x, GET_MODE (src), GET_MODE (SUBREG_REG (src)) See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79279 Validated on a private target, bootstraped on x86_64-pc-linux-gnu, but I'm not sure which target is the most relevant for this patch though ... OK to commit? Aurélien Changelog: 2017-01-27 Aurelien Buhrig * combine.c (simplify_set): Fix call to REG_CANNOT_CHANGE_MODE_CLASS_P Index: gcc/combine.c =================================================================== --- gcc/combine.c (revision 244978) +++ gcc/combine.c (working copy) @@ -6796,8 +6796,8 @@ #ifdef CANNOT_CHANGE_MODE_CLASS && ! (REG_P (dest) && REGNO (dest) < FIRST_PSEUDO_REGISTER && REG_CANNOT_CHANGE_MODE_P (REGNO (dest), - GET_MODE (SUBREG_REG (src)), - GET_MODE (src))) + GET_MODE (src), + GET_MODE (SUBREG_REG (src)))) #endif && (REG_P (dest) || (GET_CODE (dest) == SUBREG