| Message ID | db4a48fd-8c55-b344-f009-a5b38e4c069d@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [committed] Trivial testsuite fix to cope with Indu's recent change | expand |
This regression slipped in because my testing was a week old. The predict-22.c is a commit of Nov 28. Thanks Jeff. I saw this regression yesterday and was about to send the patch shortly. I should have kept the patch tested proactively. Thanks Indu On 12/01/2018 08:56 AM, Jeff Law wrote: > > Indu's change to clean up some profiling dumps clearly wasn't regression > tested as it fails on every target. > > We have an edge to a block with a call to an explicitly marked cold > function in it. We consider that a precise prediction. > > Indu's change reflects that information into the dump file, changing it > from "count 0," to "count 0 (precise),". > > This change fixes the test. Indu, please do a regression test on your > changes. That's standard procedure to avoid this kind of problem. > > Installing on the trunk. > > jeff
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c5ca4be86c4..18e08062163 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-12-01 Jeff Law <law@redhat.com> + + * gcc.dg/predict-22.c: Update expected output. + 2018-12-01 Jakub Jelinek <jakub@redhat.com> PR target/54589 diff --git a/gcc/testsuite/gcc.dg/predict-22.c b/gcc/testsuite/gcc.dg/predict-22.c index 0d50c81ebce..a613d266ea8 100644 --- a/gcc/testsuite/gcc.dg/predict-22.c +++ b/gcc/testsuite/gcc.dg/predict-22.c @@ -55,5 +55,5 @@ foo (int x, int y, int z) baz (&f); } /* { dg-final { scan-tree-dump-times "Invalid sum" 0 "optimized"} } */ -/* { dg-final { scan-tree-dump-times "count 0," 1 "optimized"} } */ +/* { dg-final { scan-tree-dump-times "count 0 .precise.," 1 "optimized"} } */ /* { dg-final { scan-rtl-dump-times "COLD_PARTITION" 1 "bbpart"} } */
Indu's change to clean up some profiling dumps clearly wasn't regression tested as it fails on every target. We have an edge to a block with a call to an explicitly marked cold function in it. We consider that a precise prediction. Indu's change reflects that information into the dump file, changing it from "count 0," to "count 0 (precise),". This change fixes the test. Indu, please do a regression test on your changes. That's standard procedure to avoid this kind of problem. Installing on the trunk. jeff commit 0a0f643d48dc019090042b18fb1f09f21accf640 Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4> Date: Sat Dec 1 16:52:22 2018 +0000 * gcc.dg/predict-22.c: Update expected output. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@266709 138bc75d-0d04-0410-961f-82ee72b054a4