diff mbox series

Fix a test (PR testsuite/89441).

Message ID ce563cda-338a-f976-c9b5-94a295b83e31@suse.cz
State New
Headers show
Series Fix a test (PR testsuite/89441). | expand

Commit Message

Martin Liška Feb. 22, 2019, 10:21 a.m. UTC 
Hi.

This patch makes main not hidden (as reported in the PR).
John: Can you verify it fixes your problem on hppa64-hp-hpux11.11 target?

Ready for trunk?

gcc/testsuite/ChangeLog:

2019-02-22  Martin Liska  <mliska@suse.cz>

	PR testsuite/89441
	* g++.dg/ipa/pr89009.C (push): Don't make main hidden.
---
 gcc/testsuite/g++.dg/ipa/pr89009.C | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

John David Anglin Feb. 22, 2019, 2:40 p.m. UTC | #1 
Hi Martin,

On 2019-02-22 5:21 a.m., Martin Liška wrote:
> Hi.
> 
> This patch makes main not hidden (as reported in the PR).
> John: Can you verify it fixes your problem on hppa64-hp-hpux11.11 target?
Your patch fixed the problem on the hppa64-hp-hpux11.11 target but we also need to
require visibility support on 32-bit hppa-hpux.  See attached.

Dave
Martin Liška Feb. 26, 2019, 9:44 a.m. UTC | #2 
On 2/22/19 3:40 PM, John David Anglin wrote:
> Hi Martin,
> 
> On 2019-02-22 5:21 a.m., Martin Liška wrote:
>> Hi.
>>
>> This patch makes main not hidden (as reported in the PR).
>> John: Can you verify it fixes your problem on hppa64-hp-hpux11.11 target?
> Your patch fixed the problem on the hppa64-hp-hpux11.11 target but we also need to
> require visibility support on 32-bit hppa-hpux.  See attached.

I see, thanks. Feel free to install the patch.

Martin

> 
> Dave
>
diff mbox series

Patch

diff --git a/gcc/testsuite/g++.dg/ipa/pr89009.C b/gcc/testsuite/g++.dg/ipa/pr89009.C
index 6b4fc65a641..b303ef99142 100644
--- a/gcc/testsuite/g++.dg/ipa/pr89009.C
+++ b/gcc/testsuite/g++.dg/ipa/pr89009.C
@@ -1,11 +1,11 @@ 
 /* PR ipa/89009 */
 /* { dg-do run } */
-/* { dg-options "-fvisibility=hidden -fpic -O2 -fno-inline" } */
+/* { dg-options "-fpic -O2 -fno-inline" } */
 
-#pragma GCC visibility push(default)
 void foo1() { __builtin_printf ("foo\n"); }
-#pragma GCC visibility pop
+#pragma GCC visibility push(hidden)
 void foo2() { __builtin_printf ("foo\n"); }
+#pragma GCC visibility pop
 
 int main() { foo2(); return 0; }