From patchwork Thu Oct 25 22:56:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Segher Boessenkool X-Patchwork-Id: 194321 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4A6152C009F for ; Fri, 26 Oct 2012 09:57:45 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1351810666; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:Date:Message-Id:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=nE0IUUoL6WQNRQiB2NQxkENatOI=; b=rf0kT4wO6SiTg4l Snmm4ij1epd4sI8vkG/a1CvUZh2AJ+x1qOehOLORfYc5skKbjOk9ucUVFY1dXX66 oQlFcF810qSDJnmoScl4QYVaxBlcugOWwUKu1YLeotJt696NNte1Bhv5w7++0vs5 kSHMRGcni1dSJk1MLTnS0JAW867I= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:Date:Message-Id:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Z9JmgCgsLRcbQE/iOl2bvzHTCrIecaJsbyYsuhum8VVavAyehbI3p+pERs2djs GnmcIgsEz+CjyDlRNErJtesGswpzAvl2s2j9WxN8nOi6ZWTtnt3zqMkARtmcBf6K o+WZPXhRBqF8RFvBph5gGmIeF/22cORIECCiy4A1c8Ijs=; Received: (qmail 22573 invoked by alias); 25 Oct 2012 22:57:40 -0000 Received: (qmail 22560 invoked by uid 22791); 25 Oct 2012 22:57:39 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SARE_MSGID_LONG40 X-Spam-Check-By: sourceware.org Received: from gcc1-power7.osuosl.org (HELO gcc1-power7.osuosl.org) (140.211.15.137) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Oct 2012 22:57:33 +0000 Received: from gcc1-power7.osuosl.org (localhost [127.0.0.1]) by gcc1-power7.osuosl.org (8.14.5/8.14.5) with ESMTP id q9PMu84a049483; Thu, 25 Oct 2012 15:56:08 -0700 Received: (from segher@localhost) by gcc1-power7.osuosl.org (8.14.5/8.14.5/Submit) id q9PMu67l049091; Thu, 25 Oct 2012 15:56:06 -0700 From: Segher Boessenkool To: gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, Segher Boessenkool Subject: [PATCH] rs6000: Correct ATOMIC mode iterator Date: Thu, 25 Oct 2012 15:56:03 -0700 Message-Id: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This fixes the ICE with -m32 -mpowerpc64 on many of the testcases that use atomics: gcc: -# of expected passes 108465 -# of unexpected failures 365 +# of expected passes 108499 +# of unexpected failures 303 libgomp: -# of expected passes 8664 -# of unexpected failures 126 -# of unresolved testcases 63 +# of expected passes 8790 Not bad for a one-liner :-) Bootstrapped and tested on powerpc64-linux, -m64,-m32,-m32/-mpowerpc64; no new failures, and the above improvements. Okay to apply? Segher 2012-10-25 Segher Boessenkool gcc/ * config/rs6000/sync.md (ATOMIC): Correct DI condition. --- gcc/config/rs6000/sync.md | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gcc/config/rs6000/sync.md b/gcc/config/rs6000/sync.md index 42ac903..ddf2ae7 100644 --- a/gcc/config/rs6000/sync.md +++ b/gcc/config/rs6000/sync.md @@ -174,7 +174,7 @@ (define_expand "atomic_store" ;; opcode that is "phased-in". Not implemented as of Power7, so not yet used, ;; but let's prepare the macros anyway. -(define_mode_iterator ATOMIC [SI (DI "TARGET_64BIT")]) +(define_mode_iterator ATOMIC [SI (DI "TARGET_POWERPC64")]) (define_insn "load_locked" [(set (match_operand:ATOMIC 0 "gpc_reg_operand" "=r")