diff mbox series

[pushed] jit: Initialize function::m_blocks in ctor

Message ID bca00dac-9092-6cd2-f35a-2d91e8cbfdf5@suse.cz
State New
Headers show
Series [pushed] jit: Initialize function::m_blocks in ctor | expand

Commit Message

Martin Liška Nov. 24, 2021, 9:17 a.m. UTC 
This resolves the problem reported here:
https://mail.gnu.org/archive/html/bug-gnu-emacs/2021-11/msg00606.html
https://bugzilla.opensuse.org/show_bug.cgi?id=1192951

I'm going to push it as obvious.

Martin

gcc/jit/ChangeLog:

	* jit-playback.c (function): Initialize m_blocks vector.
---
  gcc/jit/jit-playback.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Andrea Corallo Nov. 24, 2021, 10:06 a.m. UTC | #1 
Martin Liška <mliska@suse.cz> writes:

> This resolves the problem reported here:
> https://mail.gnu.org/archive/html/bug-gnu-emacs/2021-11/msg00606.html
> https://bugzilla.opensuse.org/show_bug.cgi?id=1192951
>
> I'm going to push it as obvious.
>
> Martin

Hi Martin,

thanks for the fix!

Question: that piece of code is there since 2014, should we back-port
the fix as well?

Best Regards

  Andrea
Martin Liška Nov. 24, 2021, 10:31 a.m. UTC | #2 
On 11/24/21 11:06, Andrea Corallo wrote:
> Martin Liška <mliska@suse.cz> writes:
> 
>> This resolves the problem reported here:
>> https://mail.gnu.org/archive/html/bug-gnu-emacs/2021-11/msg00606.html
>> https://bugzilla.opensuse.org/show_bug.cgi?id=1192951
>>
>> I'm going to push it as obvious.
>>
>> Martin
> 
> Hi Martin,
> 
> thanks for the fix!

You're welcome.

> 
> Question: that piece of code is there since 2014, should we back-port
> the fix as well?

I've just pushed to to all active code streams (master, releases/gcc-{9,10,11}).

Cheers,
Martin

> 
> Best Regards
> 
>    Andrea
>
Andrea Corallo Nov. 24, 2021, 10:37 a.m. UTC | #3 
Martin Liška <mliska@suse.cz> writes:

[...]

>> Question: that piece of code is there since 2014, should we
>> back-port
>> the fix as well?
>
> I've just pushed to to all active code streams (master, releases/gcc-{9,10,11}).

Wonderful, thanks again.

  Andrea
diff mbox series

Patch

diff --git a/gcc/jit/jit-playback.c b/gcc/jit/jit-playback.c
index 59399dee251..b412eae6aa8 100644
--- a/gcc/jit/jit-playback.c
+++ b/gcc/jit/jit-playback.c
@@ -1484,7 +1484,8 @@  function (context *ctxt,
  : m_ctxt(ctxt),
    m_inner_fndecl (fndecl),
    m_inner_bind_expr (NULL),
-  m_kind (kind)
+  m_kind (kind),
+  m_blocks ()
  {
    if (m_kind != GCC_JIT_FUNCTION_IMPORTED)
      {