| Message ID | b715bfa1-8603-b357-2a95-d9d56f7fddfd@suse.cz |
|---|---|
| State | New |
| Headers | show |
| Series | Fix spacing in symtab_node::dump_references. | expand |
Hi, On Mon, Apr 20 2020, Martin Liška wrote: > Hi. > > The patch is about a space printed in between multiple > entries in Referring and References in symtab_node dump. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Given that "called by" and "calls" cgraph_edge list dumps also do not care about producing trailing spaces, I guess this is consistent and fine, except that... > > gcc/ChangeLog: > > 2020-04-20 Martin Liska <mliska@suse.cz> > > * symtab.c (symtab_node::dump_references): Add space after > one entry. > (symtab_node::dump_referring): Likewise. > --- > gcc/symtab.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > > diff --git a/gcc/symtab.c b/gcc/symtab.c > index a36cdccf9c1..cced6bd8ac7 100644 > --- a/gcc/symtab.c > +++ b/gcc/symtab.c > @@ -800,11 +800,10 @@ symtab_node::dump_references (FILE *file) > int i; > for (i = 0; iterate_reference (i, ref); i++) > { > - fprintf (file, "%s (%s)", > - ref->referred->dump_asm_name (), > - ipa_ref_use_name [ref->use]); > + fprintf (file, "%s (%s) ", ref->referred->dump_asm_name (), > + ipa_ref_use_name[ref->use]); > if (ref->speculative) > - fprintf (file, " (speculative)"); > + fprintf (file, "(speculative)"); ...you probably want a trailing space also here, > } > fprintf (file, "\n"); > } > @@ -818,11 +817,10 @@ symtab_node::dump_referring (FILE *file) > int i; > for (i = 0; iterate_referring(i, ref); i++) > { > - fprintf (file, "%s (%s)", > - ref->referring->dump_asm_name (), > - ipa_ref_use_name [ref->use]); > + fprintf (file, "%s (%s) ", ref->referring->dump_asm_name (), > + ipa_ref_use_name[ref->use]); > if (ref->speculative) > - fprintf (file, " (speculative)"); > + fprintf (file, "(speculative) "); like you already have here. Martin
On 4/20/20 1:03 PM, Martin Jambor wrote: > Hi, > > On Mon, Apr 20 2020, Martin Liška wrote: >> Hi. >> >> The patch is about a space printed in between multiple >> entries in Referring and References in symtab_node dump. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > Given that "called by" and "calls" cgraph_edge list dumps also do not > care about producing trailing spaces, I guess this is consistent and > fine, except that... Yes, we don't care about trailing spaces. > >> >> gcc/ChangeLog: >> >> 2020-04-20 Martin Liska <mliska@suse.cz> >> >> * symtab.c (symtab_node::dump_references): Add space after >> one entry. >> (symtab_node::dump_referring): Likewise. >> --- >> gcc/symtab.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> >> diff --git a/gcc/symtab.c b/gcc/symtab.c >> index a36cdccf9c1..cced6bd8ac7 100644 >> --- a/gcc/symtab.c >> +++ b/gcc/symtab.c >> @@ -800,11 +800,10 @@ symtab_node::dump_references (FILE *file) >> int i; >> for (i = 0; iterate_reference (i, ref); i++) >> { >> - fprintf (file, "%s (%s)", >> - ref->referred->dump_asm_name (), >> - ipa_ref_use_name [ref->use]); >> + fprintf (file, "%s (%s) ", ref->referred->dump_asm_name (), >> + ipa_ref_use_name[ref->use]); >> if (ref->speculative) >> - fprintf (file, " (speculative)"); >> + fprintf (file, "(speculative)"); > > ...you probably want a trailing space also here, Yes, thank you! I'm going to install the patch with this adjusted. Thanks, Martin > >> } >> fprintf (file, "\n"); >> } >> @@ -818,11 +817,10 @@ symtab_node::dump_referring (FILE *file) >> int i; >> for (i = 0; iterate_referring(i, ref); i++) >> { >> - fprintf (file, "%s (%s)", >> - ref->referring->dump_asm_name (), >> - ipa_ref_use_name [ref->use]); >> + fprintf (file, "%s (%s) ", ref->referring->dump_asm_name (), >> + ipa_ref_use_name[ref->use]); >> if (ref->speculative) >> - fprintf (file, " (speculative)"); >> + fprintf (file, "(speculative) "); > > like you already have here. > > Martin >
diff --git a/gcc/symtab.c b/gcc/symtab.c index a36cdccf9c1..cced6bd8ac7 100644 --- a/gcc/symtab.c +++ b/gcc/symtab.c @@ -800,11 +800,10 @@ symtab_node::dump_references (FILE *file) int i; for (i = 0; iterate_reference (i, ref); i++) { - fprintf (file, "%s (%s)", - ref->referred->dump_asm_name (), - ipa_ref_use_name [ref->use]); + fprintf (file, "%s (%s) ", ref->referred->dump_asm_name (), + ipa_ref_use_name[ref->use]); if (ref->speculative) - fprintf (file, " (speculative)"); + fprintf (file, "(speculative)"); } fprintf (file, "\n"); } @@ -818,11 +817,10 @@ symtab_node::dump_referring (FILE *file) int i; for (i = 0; iterate_referring(i, ref); i++) { - fprintf (file, "%s (%s)", - ref->referring->dump_asm_name (), - ipa_ref_use_name [ref->use]); + fprintf (file, "%s (%s) ", ref->referring->dump_asm_name (), + ipa_ref_use_name[ref->use]); if (ref->speculative) - fprintf (file, " (speculative)"); + fprintf (file, "(speculative) "); } fprintf (file, "\n"); }