| Message ID | alpine.LSU.2.21.1905261945350.7670@anthias.pfeifer.com |
|---|---|
| State | New |
| Headers | show |
| Series | [libstdc++,doc] doc/xml/manual/support.xml - link adjustment and simplification | expand |
On 26/05/19 19:46 +0200, Gerald Pfeifer wrote: >The links adjustment I would just have committed right away, but >I'd also like to suggest swe simplify the section: the following >paragraph doesn't really add much, but duplicates the external >link. > >Thoughts? It's the same link, but not the same reference. One is pointing to the advice in the book, and one is pointing to the accompanying example code that is available in the CDROM version of the book. That whole file needs updates, it's all out of date (C++11 adds nullptr as a better alternative to NULL, and in the next section the list of six flavours is waaaaaaay out of date, as there are several new overloads in recent standards). >Gerald > >2019-05-26 Gerald Pfeifer <gerald@pfeifer.com> > > * doc/xml/manual/support.xml: Adjust link to www.aristeia.com. > Shorten the section a bit. > >Index: doc/xml/manual/support.xml >=================================================================== >--- doc/xml/manual/support.xml (revision 271632) >+++ doc/xml/manual/support.xml (working copy) >@@ -170,7 +170,7 @@ > </para> > > <para>In his book <link xmlns:xlink="http://www.w3.org/1999/xlink" >- xlink:href="http://www.aristeia.com/books.html"><emphasis>Effective >+ xlink:href="https://www.aristeia.com/books.html"><emphasis>Effective > C++</emphasis></link>, Scott Meyers points out that the best way > to solve this problem is to not overload on pointer-vs-integer > types to begin with. He also offers a way to make your own magic >@@ -177,11 +177,6 @@ > <constant>NULL</constant> that will match pointers before it > matches integers. > </para> >- <para>See the >- <link xmlns:xlink="http://www.w3.org/1999/xlink" >- xlink:href="http://www.aristeia.com/books.html"><emphasis>Effective >- C++ CD</emphasis></link> example. >- </para> > </section> > > </section>
On 28/05/19 17:24 +0100, Jonathan Wakely wrote: >On 26/05/19 19:46 +0200, Gerald Pfeifer wrote: >>The links adjustment I would just have committed right away, but >>I'd also like to suggest swe simplify the section: the following >>paragraph doesn't really add much, but duplicates the external >>link. >> >>Thoughts? > >It's the same link, but not the same reference. One is pointing to the >advice in the book, and one is pointing to the accompanying example >code that is available in the CDROM version of the book. > >That whole file needs updates, it's all out of date (C++11 adds >nullptr as a better alternative to NULL, and in the next section the >list of six flavours is waaaaaaay out of date, as there are several >new overloads in recent standards). I decided to make a few small changes, and ended up rewriting several sections. Committed to trunk.
On Thu, 30 May 2019, Jonathan Wakely wrote: > I decided to make a few small changes, and ended up rewriting several > sections. Committed to trunk. Thank you! That also nicely addressed the changed URLs I had noticed. Gerald
Index: doc/xml/manual/support.xml =================================================================== --- doc/xml/manual/support.xml (revision 271632) +++ doc/xml/manual/support.xml (working copy) @@ -170,7 +170,7 @@ </para> <para>In his book <link xmlns:xlink="http://www.w3.org/1999/xlink" - xlink:href="http://www.aristeia.com/books.html"><emphasis>Effective + xlink:href="https://www.aristeia.com/books.html"><emphasis>Effective C++</emphasis></link>, Scott Meyers points out that the best way to solve this problem is to not overload on pointer-vs-integer types to begin with. He also offers a way to make your own magic @@ -177,11 +177,6 @@ <constant>NULL</constant> that will match pointers before it matches integers. </para> - <para>See the - <link xmlns:xlink="http://www.w3.org/1999/xlink" - xlink:href="http://www.aristeia.com/books.html"><emphasis>Effective - C++ CD</emphasis></link> example. - </para> </section> </section>