| Message ID | alpine.LSU.2.11.1506021408200.30088@zhemvz.fhfr.qr |
|---|---|
| State | New |
| Headers | show |
On June 2, 2015 2:08:47 PM GMT+02:00, Richard Biener <rguenther@suse.de> wrote: > >Committed. Seems to cause half of the vectorizer tests to be dropped >and test-summary breaking for me. Right. There should be no cleanup-tree-dump left on trunk. Thanks, > >Richard. > >2015-06-02 Richard Biener <rguenther@suse.de> > > * gcc.dg/vect/vect-outer-simd-1.c: Remove stray cleanup-tree-dump. > >Index: gcc/testsuite/gcc.dg/vect/vect-outer-simd-1.c >=================================================================== >--- gcc/testsuite/gcc.dg/vect/vect-outer-simd-1.c (revision 224013) >+++ gcc/testsuite/gcc.dg/vect/vect-outer-simd-1.c (working copy) >@@ -72,4 +72,3 @@ int main() > return 0; > } > /* { dg-final { scan-tree-dump "OUTER LOOP VECTORIZED" "vect" } } */ >-/* { dg-final { cleanup-tree-dump "vect" } } */
[just a try to keep fallout low] On June 2, 2015 5:38:06 PM GMT+02:00, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote: >On June 2, 2015 2:08:47 PM GMT+02:00, Richard Biener ><rguenther@suse.de> wrote: >> >>Committed. Seems to cause half of the vectorizer tests to be dropped >>and test-summary breaking for me. As a gentle reminder to reviewers and all: >Right. There should be no cleanup-tree-dump left on trunk. On Friday I committed: * lib/gcc-dg.exp (cleanup-ipa-dump, cleanup-rtl-dump, cleanup-tree-dump, cleanup-dump, cleanup-saved-temps): Remove. Adjust all callers. Please refer to sourcebuild.texi for (currently) remaining manual cleanup tcl procs. Thanks and cheers,
On 02/06/15 20:40, Bernhard Reutner-Fischer wrote: > On June 2, 2015 5:38:06 PM GMT+02:00, Bernhard Reutner-Fischer<rep.dot.nop@gmail.com> wrote: >> >On June 2, 2015 2:08:47 PM GMT+02:00, Richard Biener >> ><rguenther@suse.de> wrote: >>> >> >>> >>Committed. Seems to cause half of the vectorizer tests to be dropped >>> >>and test-summary breaking for me. > As a gentle reminder to reviewers and all: > >> >Right. There should be no cleanup-tree-dump left on trunk. My overnight testing of a patch also broke on a harmless cleanup-tree-dump. What is the rationale to have this as an error rather than a warning? Thanks, - Tom
On Jun 5, 2015, at 4:02 AM, Tom de Vries <Tom_deVries@mentor.com> wrote: > On 02/06/15 20:40, Bernhard Reutner-Fischer wrote: >> On June 2, 2015 5:38:06 PM GMT+02:00, Bernhard Reutner-Fischer<rep.dot.nop@gmail.com> wrote: >>> >On June 2, 2015 2:08:47 PM GMT+02:00, Richard Biener >>> ><rguenther@suse.de> wrote: >>>> >> >>>> >>Committed. Seems to cause half of the vectorizer tests to be dropped >>>> >>and test-summary breaking for me. >> As a gentle reminder to reviewers and all: >> >>> >Right. There should be no cleanup-tree-dump left on trunk. > > My overnight testing of a patch also broke on a harmless cleanup-tree-dump. > > What is the rationale to have this as an error rather than a warning? So that we can clean up trunk and ensure no one puts dirty stuff on it?
Index: gcc/testsuite/gcc.dg/vect/vect-outer-simd-1.c =================================================================== --- gcc/testsuite/gcc.dg/vect/vect-outer-simd-1.c (revision 224013) +++ gcc/testsuite/gcc.dg/vect/vect-outer-simd-1.c (working copy) @@ -72,4 +72,3 @@ int main() return 0; } /* { dg-final { scan-tree-dump "OUTER LOOP VECTORIZED" "vect" } } */ -/* { dg-final { cleanup-tree-dump "vect" } } */