diff mbox

Fix PR64044

Message ID alpine.LSU.2.11.1411241324470.374@zhemvz.fhfr.qr
State New
Headers show

Commit Message

Richard Biener Nov. 24, 2014, 12:29 p.m. UTC 
The following fixes an issue I found when more aggressively 
constant-folding from static initializers.  The Java frontend
fails to provide an initializer for the classdollar field
it creates but nevertheless marks them with TREE_READONLY
whilst being static.

Thus the following patch removes setting of TREE_READONLY.

Bootstrap & regtest running on x86_64-unknown-linux-gnu.

Ok?

Thanks,
Richard.

2014-11-24  Richard Biener  <rguenther@suse.de>

	PR java/64004
	* class.c (build_classdollar_field): Do not set TREE_READONLY.

Comments

Andrew Haley Nov. 24, 2014, 12:46 p.m. UTC | #1 
On 11/24/2014 12:29 PM, Richard Biener wrote:
> 
> The following fixes an issue I found when more aggressively 
> constant-folding from static initializers.  The Java frontend
> fails to provide an initializer for the classdollar field
> it creates but nevertheless marks them with TREE_READONLY
> whilst being static.
> 
> Thus the following patch removes setting of TREE_READONLY.
> 
> Bootstrap & regtest running on x86_64-unknown-linux-gnu.
> 
> Ok?

OK, thanks.

Andrew.
diff mbox

Patch

Index: gcc/java/class.c
===================================================================
--- gcc/java/class.c	(revision 218010)
+++ gcc/java/class.c	(working copy)
@@ -1085,7 +1085,6 @@  build_classdollar_field (tree type)
 			TYPE_QUAL_CONST)));
       TREE_STATIC (decl) = 1;
       TREE_CONSTANT (decl) = 1;
-      TREE_READONLY (decl) = 1;
       TREE_PUBLIC (decl) = 1;
       java_hide_decl (decl);
       DECL_IGNORED_P (decl) = 1;