diff mbox

[wide-int] template <typename T> class generic_wide_int in wide-int.h

Message ID alpine.LSU.2.11.1408161340220.3591@tuna.site
State New
Headers show

Commit Message

Gerald Pfeifer Aug. 17, 2014, 12:28 a.m. UTC 
The patch below shaves 404 warnings from stage 1 when bootstrapping
with clang 3.4.1 (i386-unknown-freebsd10.0).

Regardless of whether we agree with that warning in clang, keeping 
things consistent and not using struct once and class in other places 
makes sense.  And I believe Mike was affirmative re a similar patch
last month.

Applied.

Gerald

2014-08-16  Gerald Pfeifer  <gerald@pfeifer.com>

	* wide-int.h (generic_wide_int): Declare as class instead of struct.

Comments

Mike Stump Aug. 17, 2014, 12:38 a.m. UTC | #1 
On Aug 16, 2014, at 5:28 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> The patch below shaves 404 warnings from stage 1 when bootstrapping
> with clang 3.4.1 (i386-unknown-freebsd10.0).
> 
> Regardless of whether we agree with that warning in clang, keeping 
> things consistent and not using struct once and class in other places 
> makes sense.  And I believe Mike was affirmative re a similar patch
> last month.

Yes, regardless of what we think of clang, we did not intentionally want the tags to differ.

> Applied.

Thanks.
diff mbox

Patch

Index: wide-int.h
===================================================================
--- wide-int.h	(revision 214062)
+++ wide-int.h	(working copy)
@@ -282,7 +282,7 @@ 
     wi::int_traits <WI_UNARY_RESULT (T)>::get_binary_result (X, X); \
   HOST_WIDE_INT *VAL = RESULT.write_val ()
 
-template <typename T> struct generic_wide_int;
+template <typename T> class generic_wide_int;
 template <int N> struct fixed_wide_int_storage;
 class wide_int_storage;