From patchwork Tue Feb 12 11:15:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 219789 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 280112C007B for ; Tue, 12 Feb 2013 22:15:43 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1361272544; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=lQoNbloHNz42PK6lZcor SShjeMU=; b=ItwXLD1o2oDRCOwE0p3Z8YyJBIjxjCdkjkDY9m3EVY32e36v0Jft oTsmzHn/37UacckBjR/lty8yzAaUj90nPeDL3Q8wgl2SMtUMRy4RlcRNKnW+dOF2 XAwhokLXBcV8OoOnUPbEUxRLze1Tq/ufnKyMcCaGctEZ0rC74FdUwtg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=hdiD6DEWM+UAQ9pGysoy0/U02cxqONqsPKtXky9siYB5a365PyoH0/E8COyNfw V4fYKUB8Q6x/hgPoTBGcMhNoFjWeXpmDFv/udoNbAsKASRd0HWRW2uxXQjDakzH+ fRcEInljdzdrIz28W46nMFw534n6F4KwUbKXW4wr6gXSM=; Received: (qmail 5066 invoked by alias); 12 Feb 2013 11:15:37 -0000 Received: (qmail 5051 invoked by uid 22791); 12 Feb 2013 11:15:35 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Feb 2013 11:15:31 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 4495EA5212 for ; Tue, 12 Feb 2013 12:15:30 +0100 (CET) Date: Tue, 12 Feb 2013 12:15:30 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix PR56288 Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This fixes a oversight when introducing anonymous SSA names. I managed to change a checking piece to a noop. Oops. I took the opportunity to move the freelist check earlier, as the type check would trigger for freed SSA names as well. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-02-12 Richard Biener PR middle-end/56288 * tree-ssa.c (verify_ssa_name): Fix check, move SSA_NAME_IN_FREE_LIST check up. Index: gcc/tree-ssa.c =================================================================== --- gcc/tree-ssa.c (revision 195941) +++ gcc/tree-ssa.c (working copy) @@ -626,16 +626,16 @@ verify_ssa_name (tree ssa_name, bool is_ return true; } - if (SSA_NAME_VAR (ssa_name) != NULL_TREE - && TREE_TYPE (ssa_name) != TREE_TYPE (ssa_name)) + if (SSA_NAME_IN_FREE_LIST (ssa_name)) { - error ("type mismatch between an SSA_NAME and its symbol"); + error ("found an SSA_NAME that had been released into the free pool"); return true; } - if (SSA_NAME_IN_FREE_LIST (ssa_name)) + if (SSA_NAME_VAR (ssa_name) != NULL_TREE + && TREE_TYPE (ssa_name) != TREE_TYPE (SSA_NAME_VAR (ssa_name))) { - error ("found an SSA_NAME that had been released into the free pool"); + error ("type mismatch between an SSA_NAME and its symbol"); return true; }