From patchwork Mon Sep 17 21:00:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerald Pfeifer X-Patchwork-Id: 184543 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8A1D62C0086 for ; Tue, 18 Sep 2012 07:01:13 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1348520474; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=s2t1v17kjr2d3BMSV/C/++h8tKg=; b=wkaDJwbYwn0mPg1 zTO4knWjqe/GCkYNwtY8BrvuCGkVzNEDrl1E2JUYSVq4+5q/75blUozak7+OjdKN e0G6HleU5/LpkUfsqrysYZgsxMQT3Nw1x2m+ecskkiTnfDkOeuRHPHjdoY3SRDJY 6q2oIBDN3gNk/0F5E4D9iUKFjdC4= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=WvVc2GUL1Hyr/0J6GQlJhx35a8kJKEcDIHdON+ZzZLN8XrUN7JGvbb32Vs9rCr REb+foDzbpk42zLiZnDGcZ2nReaYhH9iJAeNVqr/IvxgLYqatCRF+4YOdZ6o/P3M x7kTI8nygMv4EvPoRjLTbCVdH+Lu9+jDxnsiasFPJHXe4=; Received: (qmail 31520 invoked by alias); 17 Sep 2012 21:01:08 -0000 Received: (qmail 31500 invoked by uid 22791); 17 Sep 2012 21:01:07 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=BAYES_00, KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from ainaz.pair.com (HELO ainaz.pair.com) (209.68.2.66) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Sep 2012 21:00:54 +0000 Received: from [199.72.56.154] (unknown [199.72.56.154]) by ainaz.pair.com (Postfix) with ESMTPSA id AADCD3F40F; Mon, 17 Sep 2012 17:00:52 -0400 (EDT) Date: Mon, 17 Sep 2012 17:00:59 -0400 (EDT) From: Gerald Pfeifer To: Ian Lance Taylor cc: Diego Novillo , gcc-patches@gcc.gnu.org Subject: Re: Backtrace library [1/3] In-Reply-To: Message-ID: References: <50523B75.105@google.com> MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, 17 Sep 2012, Ian Lance Taylor wrote: > Please let me know about any build problems. i386-unknown-freebsd10.0 now fails as follows. Others presumably have not run into this since "This source file is compiled if the unwind library is not available". /scratch2/tmp/gerald/gcc-HEAD/libbacktrace/nounwind.c:48: warning: no previous prototype for 'backtrace' /scratch2/tmp/gerald/gcc-HEAD/libbacktrace/nounwind.c:59: error: conflicting types for 'backtrace_simple' /scratch2/tmp/gerald/gcc-HEAD/libbacktrace/backtrace.h:130: error: previous declaration of 'backtrace_simple' was here gmake[4]: *** [nounwind.lo] Error 1 gmake[4]: Leaving directory `/scratch2/tmp/gerald/OBJ-0917-1906/libbacktrace' gmake[3]: *** [all] Error 2 gmake[3]: Leaving directory `/scratch2/tmp/gerald/OBJ-0917-1906/libbacktrace' gmake[2]: *** [all-stage1-libbacktrace] Error 2 gmake[2]: Leaving directory `/scratch2/tmp/gerald/OBJ-0917-1906' gmake[1]: *** [stage1-bubble] Error 2 gmake[1]: Leaving directory `/scratch2/tmp/gerald/OBJ-0917-1906' gmake: *** [bootstrap-lean] Error 2 Tracked as http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54611 . There are two different issues breaking the build here. The following patch, which I committed as obvious, addresses the second. Tested by ensuring the bootstrap on this platform is now only breaking due to the first item. 2012-09-17 Gerald Pfeifer PR bootstrap/54611 * nounwind.c (backtrace_simple): Add state parameter. I'm running out of time now, but will check again later today or tomorrow for the other item (hoping it'll been magically gone ;-). Gerald Index: nounwind.c =================================================================== --- nounwind.c (revision 191404) +++ nounwind.c (working copy) @@ -53,7 +53,8 @@ } int -backtrace_simple (int skip ATTRIBUTE_UNUSED, +backtrace_simple (struct backtrace_state *state ATTRIBUTE_UNUSED, + int skip ATTRIBUTE_UNUSED, backtrace_simple_callback callback ATTRIBUTE_UNUSED, backtrace_error_callback error_callback, void *data) {