Message ID | alpine.LNX.2.00.1108241317570.2130@zhemvz.fhfr.qr |
---|---|
State | New |
Headers | show |
Hi, On Wed, 24 Aug 2011, Richard Guenther wrote: > This avoids the file/location clutter in front of each line in the > vectorizer dump. While this is useful for people requesting > -fvectorizer-verbose=N in dump files this makes you unable to compare > dumps for testcases on a branch and trunk. It also makes lines > excessively long because the testsuite filename paths are so long. > Very annoying. While the repetition is indeed annoying I put the location marker to good use for files with multiple loops. Just searching for "123:" jumped you to the dump block where the interesting loop started to be analyzed. Same for searching from the end, where it put you right at the final decision. I would very much prefer if that would still be possible, possibly by using "start to analyze loop at file:123" and "finished with loop at file:123". Ciao, Michael.
On Wed, 24 Aug 2011, Michael Matz wrote: > Hi, > > On Wed, 24 Aug 2011, Richard Guenther wrote: > > > This avoids the file/location clutter in front of each line in the > > vectorizer dump. While this is useful for people requesting > > -fvectorizer-verbose=N in dump files this makes you unable to compare > > dumps for testcases on a branch and trunk. It also makes lines > > excessively long because the testsuite filename paths are so long. > > Very annoying. > > While the repetition is indeed annoying I put the location marker to good > use for files with multiple loops. Just searching for "123:" jumped you > to the dump block where the interesting loop started to be analyzed. Same > for searching from the end, where it put you right at the final decision. > > I would very much prefer if that would still be possible, possibly by > using "start to analyze loop at file:123" and "finished with loop at > file:123". Yes, that would be nice. Patches welcome ;) Richard.
Index: gcc/tree-vectorizer.c =================================================================== --- gcc/tree-vectorizer.c (revision 178028) +++ gcc/tree-vectorizer.c (working copy) @@ -149,7 +149,10 @@ vect_print_dump_info (enum vect_verbosit if (!current_function_decl || !vect_dump) return false; - if (vect_location == UNKNOWN_LOC) + if (dump_file) + fprintf (vect_dump, "\n"); + + else if (vect_location == UNKNOWN_LOC) fprintf (vect_dump, "\n%s:%d: note: ", DECL_SOURCE_FILE (current_function_decl), DECL_SOURCE_LINE (current_function_decl));