From patchwork Thu Dec 17 13:26:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 558349 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BFCFA1402BF for ; Fri, 18 Dec 2015 00:27:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=PnRzhRlK; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :date:to:cc:subject:in-reply-to:message-id:references :mime-version:content-type; q=dns; s=default; b=rEz1WF+VAFlLQQzQ fbJFI6ltxM7JXjLXTVBhaWnHzvYCLSIdOpnX0yirhOiguc2RFD3iythA5PhPdkq0 /l4G5FV4zgxnACgmg8+pcIBtUAGZW5zEouVPw03/b1S3ZKEqqlKdJ1NgYXiPd+D8 8QxnD/X+yN4v0xGjXxI3XDfg63g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :date:to:cc:subject:in-reply-to:message-id:references :mime-version:content-type; s=default; bh=RRFtagd4+c3EJmE3r1MpgS eEfbw=; b=PnRzhRlK5uCLw9X6CZPa7Srv2T/b8vbAQ26r55VkolMn4T4bqFVQv5 mvYTk8H2Wxi4SjvpZfczE2Pk2lF7CLWcKbBXfnWIXzxUoaz51i4JtEDggRg9Nwwv 43j9kBUQkVe70tdu4qco7rIr1RftCYXyVCmvDkrscIdKcjCZR5DoM= Received: (qmail 62428 invoked by alias); 17 Dec 2015 13:27:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 62359 invoked by uid 89); 17 Dec 2015 13:27:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=2, 7, Going, Hx-languages-length:3130 X-HELO: mail-qg0-f44.google.com Received: from mail-qg0-f44.google.com (HELO mail-qg0-f44.google.com) (209.85.192.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 17 Dec 2015 13:27:06 +0000 Received: by mail-qg0-f44.google.com with SMTP id c96so7115998qgd.3 for ; Thu, 17 Dec 2015 05:27:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=ENXCKJnTrI2Ua7wYFyUNT2M/XPo/IdAbjAzCGpRk54s=; b=KylrQdDSLGjeXWw8uMtNyYNSdxIRiSKNGZv5bfu4B5ezHIdjV5Uz3DlOVevZGkC9O2 cJd6msUZvtr1C5zunQjq6tsaVquNB6pI0j9Wjgk2rYX1HXDkZyiOZv23kGo6DOP7z+6o 1vGqge94dmqbdahEY22fE5LxRJdau87Bs9IsADbxp6/Z1nqeHPShfivfiQLDxf3Ey1Eb n8islnYsmd8Oz0LXdxs7euTllh1wcTihsghFFCl7SGZeJd1RprQHFHfsgVV1S03BsQZE EZOfPI2UDmrE2Mf2eqHoXeNfjhlSXGAz0/NhiEtH+Et3FNE7udxsy3tfW9BgROjSZz2E rnuA== X-Gm-Message-State: ALoCoQlnUIKUgcSjuMAZGyVDuQzN1FmXxR3lbKgFPwMdPj6xxzEfK3MRKWNOBBGXEZATAxPQTcl6jcYrGXPbssRWJ+ETDfwO4w== X-Received: by 10.140.105.101 with SMTP id b92mr68102675qgf.5.1450358823673; Thu, 17 Dec 2015 05:27:03 -0800 (PST) Received: from [192.168.1.130] (ool-4353a8be.dyn.optonline.net. [67.83.168.190]) by smtp.gmail.com with ESMTPSA id t47sm4673116qgt.28.2015.12.17.05.27.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Dec 2015 05:27:03 -0800 (PST) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Thu, 17 Dec 2015 08:26:47 -0500 (EST) To: Paolo Carlini cc: Patrick Palka , Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix some blockers of PR c++/24666 (arrays decay to pointers too early) In-Reply-To: <56728B32.5020307@oracle.com> Message-ID: References: <1450214192-23542-1-git-send-email-patrick@parcs.ath.cx> <5671D92F.1000104@redhat.com> <56728B32.5020307@oracle.com> User-Agent: Alpine 2.20.9 (DEB 106 2015-09-22) MIME-Version: 1.0 On Thu, 17 Dec 2015, Paolo Carlini wrote: > Hi, > > On 16/12/2015 23:10, Patrick Palka wrote: >> gcc/cp/ChangeLog: >> >> PR c++/59878 >> * typeck.c (convert_for_initialization): Don't perform an early >> decaying conversion if converting to a class type. >> >> gcc/testsuite/ChangeLog: >> >> PR c++/59878 >> * g++.dg/conversion/pr59878.C: New test. > Nit: note that the actual bug number is 59879, not 59878. Can you please > correct all those 8 to 9? Sorry about that... Going to correct this with the following patch after a quick regtest: --- 8< --- Subject: [PATCH] Fix wrong PR references PR c++/59878 -> PR c++/59879 --- gcc/cp/ChangeLog | 2 +- gcc/testsuite/ChangeLog | 4 ++-- gcc/testsuite/g++.dg/conversion/pr59878.C | 25 ------------------------- gcc/testsuite/g++.dg/conversion/pr59879.C | 25 +++++++++++++++++++++++++ 4 files changed, 28 insertions(+), 28 deletions(-) delete mode 100644 gcc/testsuite/g++.dg/conversion/pr59878.C create mode 100644 gcc/testsuite/g++.dg/conversion/pr59879.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 14292e9..a192f00 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -2,7 +2,7 @@ PR c++/16333 PR c++/41426 - PR c++/59878 + PR c++/59879 PR c++/66895 * typeck.c (convert_for_initialization): Don't perform an early decaying conversion if converting to a class type. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index fafa8cc..7386f6b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -37,11 +37,11 @@ PR c++/16333 PR c++/41426 - PR c++/59878 + PR c++/59879 PR c++/66895 * g++.dg/conversion/pr16333.C: New test. * g++.dg/conversion/pr41426.C: New test. - * g++.dg/conversion/pr59878.C: New test. + * g++.dg/conversion/pr59879.C: New test. * g++.dg/conversion/pr66895.C: New test. 2015-12-16 Martin Sebor diff --git a/gcc/testsuite/g++.dg/conversion/pr59878.C b/gcc/testsuite/g++.dg/conversion/pr59878.C deleted file mode 100644 index ed567fe..0000000 --- a/gcc/testsuite/g++.dg/conversion/pr59878.C +++ /dev/null @@ -1,25 +0,0 @@ -// PR c++/59878 - -struct Test { - template - Test(const char (&array)[N]) {} -}; - -Test test() { - return "test1"; -} - -void test2(Test arg = "test12") {} - -template -void test3(T arg = "test123") {} - -template -void test4(const T &arg = "test123") {} - -int main() { - test(); - test2(); - test3(); - test4(); -} diff --git a/gcc/testsuite/g++.dg/conversion/pr59879.C b/gcc/testsuite/g++.dg/conversion/pr59879.C new file mode 100644 index 0000000..7bd5b99 --- /dev/null +++ b/gcc/testsuite/g++.dg/conversion/pr59879.C @@ -0,0 +1,25 @@ +// PR c++/59879 + +struct Test { + template + Test(const char (&array)[N]) {} +}; + +Test test() { + return "test1"; +} + +void test2(Test arg = "test12") {} + +template +void test3(T arg = "test123") {} + +template +void test4(const T &arg = "test123") {} + +int main() { + test(); + test2(); + test3(); + test4(); +}