diff mbox series

libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc

Message ID alpine.BSF.2.20.16.2108072239160.55678@arjuna.pair.com
State New
Headers show
Series libstdc++: Tweak timeout for testsuite/std/ranges/iota/max_size_type.cc | expand

Commit Message

Hans-Peter Nilsson Aug. 8, 2021, 2:42 a.m. UTC 
A simulator can easily spend more than 10 minutes running this
test-case, and the default timeout is at 5 minutes. Better allow
even slower machines; use 4 as the factor.

Regarding relative runtime numbers (very local; mmixware simulator for
mmix-knuth-mmixware): test01 and test05 finish momentarily; test02 at
about 2 minutes, and test03 about 2m30, but test04 itself runs for
more than 6 minutes and so timed out.

Not sure if it's better to split up this test, as the excessive
runtime may be unintended, but this seemed simplest.

Ok to commit?

libstdc++-v3:
	* testsuite/std/ranges/iota/max_size_type.cc: Set
	dg-timeout-factor to 4.
---
 libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Wakely Aug. 8, 2021, 6:56 a.m. UTC | #1 
On Sun, 8 Aug 2021, 03:42 Hans-Peter Nilsson, <hp@bitrange.com> wrote:

> A simulator can easily spend more than 10 minutes running this
> test-case, and the default timeout is at 5 minutes. Better allow
> even slower machines; use 4 as the factor.
>
> Regarding relative runtime numbers (very local; mmixware simulator for
> mmix-knuth-mmixware): test01 and test05 finish momentarily; test02 at
> about 2 minutes, and test03 about 2m30, but test04 itself runs for
> more than 6 minutes and so timed out.
>

Strange, it does fewer iterations than test03. I guess the arithmetic is
slower.


Not sure if it's better to split up this test, as the excessive
> runtime may be unintended, but this seemed simplest.
>
> Ok to commit?
>


Ok, thanks.



> libstdc++-v3:
>         * testsuite/std/ranges/iota/max_size_type.cc: Set
>         dg-timeout-factor to 4.
> ---
>  libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> index 983bdfbdaa6c..a52e8e6231aa 100644
> --- a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> +++ b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
> @@ -17,6 +17,7 @@
>
>  // { dg-options "-std=gnu++2a" }
>  // { dg-do run { target c++2a } }
> +// { dg-timeout-factor 4 }
>
>  #include <limits>
>  #include <ranges>
> --
> 2.20.1
>
>
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
index 983bdfbdaa6c..a52e8e6231aa 100644
--- a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
+++ b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc
@@ -17,6 +17,7 @@ 

 // { dg-options "-std=gnu++2a" }
 // { dg-do run { target c++2a } }
+// { dg-timeout-factor 4 }

 #include <limits>
 #include <ranges>