From patchwork Sun Aug 26 22:20:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 180095 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A30B62C00D5 for ; Mon, 27 Aug 2012 08:21:14 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1346624475; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Date:From:To:Subject:Message-ID:User-Agent:MIME-Version: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=cFrXmxr EpjYROVQ2apsOMQ/41Go=; b=nwbIYHa2mjkqxIRdX1ZAL2kO74KjQR1eogwiZ1V 34YiUEeO2vbFdpV0QLs6IX2slyHBM/M7RnqyKjtRrVvzrv3wLj5yupr1lKo5zdCm U/2FWVAzU7s3bLzxCO6HDr50U7uSiEbdjWl1lC1tJibQk4t8qNVNtAlfz1xfw7Qv suyY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Date:From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=v6iyFVrxYuE28jNUD1QbLCvwLWwFqWM8Uc90lh3fI3pgn1E6vOyztFf/iFntnq 0YkdFtPy0DfkiGOMlL543ZfYk5XRJvMH6zxf0ZxPDcIsJfcyqnjq7xL/+JZ+UNol Dok0Xifk/YdhQMrDwDh8YVYmPwjMtw5KCkiqRDCH3cbT0=; Received: (qmail 8065 invoked by alias); 26 Aug 2012 22:21:12 -0000 Received: (qmail 8057 invoked by uid 22791); 26 Aug 2012 22:21:11 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 26 Aug 2012 22:20:56 +0000 Received: (qmail 57885 invoked by uid 20157); 26 Aug 2012 22:20:56 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 26 Aug 2012 22:20:56 -0000 Date: Sun, 26 Aug 2012 18:20:56 -0400 (EDT) From: Hans-Peter Nilsson To: gcc-patches@gcc.gnu.org Subject: To-be-committed: fix configure case when assembler COMDAT group support is lacking Message-ID: User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org If the out-of-tree target assembler supports neither: .section .text,"axG",@progbits,.foo,comdat (tsk tsk no leading space, though that's a red herring) nor: .section .text,"axG",%progbits,.foo,comdat then gcc/configure.ac drops through into the system-specific case seen in the patch, where for *-*-solaris2*, gcc_cv_as_comdat_group_group is set. (If one of the above syntaxes work, then gcc_cv_as_comdat_group_group is forced to "no".) For other systems, it is not set. In subsequent code (setting HAVE_COMDAT_GROUP), a test of that variable for such systems is seen in the build log as an error message from "test": ... checking assembler for section merging support... yes checking assembler for COMDAT group support (GNU as)... no checking assembler for COMDAT group support (GNU as, %type)... no /mnt/2/tmp/hp/testgcc/tmp/st3/gcc/gcc/configure: line 23125: test: =: unary operator expected checking assembler for line table discriminator support... yes ... I'll commit this in a while as obvious. The idiom for testing that the variable is set (N.B. "manual" settings are supposed to work) is copied from the closest variant, also the least objectionable one among the extant ones. There are lots of variants in there. :/ gcc: * configure.ac (gcc_cv_as_comdat_group_group): Default to no. * configure: Regenerate. Index: gcc/configure.ac =================================================================== --- gcc/configure.ac (revision 190682) +++ gcc/configure.ac (working copy) @@ -2630,6 +2630,9 @@ else if test $gcc_cv_as_comdat_group_percent = yes; then gcc_cv_as_comdat_group_group=no else + if test -z "${gcc_cv_as_comdat_group_group+set}"; then + gcc_cv_as_comdat_group_group=no + fi case "${target}" in # Sun as uses a completely different syntax. *-*-solaris2*)