From patchwork Mon Feb 17 12:18:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 1239183 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-519637-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=Z2jn/HlZ; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48LjhS0rvfz9sRL for ; Mon, 17 Feb 2020 23:19:03 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type; q=dns; s= default; b=yzt+pSLtJ/hRlz8xzF21YJQ6tf4zWr3A9bKQoPCPhYME22XWlayNf 4MWkN40TCk8kSc+hy7qjNUKDZTMp3OixtiUxP3ALIkKK7gOrKb4qY0nF5QttU8oB Llk8TebsGm1uwpACmstTr91c8WltmFCMvwkGEMN094OWvA87kXg2wQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type; s= default; bh=EPUIo5Ze3zF599O1IgFvwY/nV3I=; b=Z2jn/HlZsqMvcoNRJodD QQQFX5ay0emubxW1qakP6t/+G1KZH+3XcycV7uUcRGf/3J+iZ+OvPKQfNBwmBnp4 FBNK4tBK4mZGtonDFeKMcy6fDecGklf/Ra5T/peCBvjJ+UCKZXt/5p+Cejw9CMLS W5ZaHZGeDWzBb9ZTh2/bPlk= Received: (qmail 23130 invoked by alias); 17 Feb 2020 12:18:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23121 invoked by uid 89); 17 Feb 2020 12:18:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=warned, constructed, UD:ipa-devirt.c, ipa-devirt.c X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 12:18:55 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 088B1B0B3 for ; Mon, 17 Feb 2020 12:18:53 +0000 (UTC) From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH][OBVIOUS] Fix grammar in error message. To: gcc-patches@gcc.gnu.org Message-ID: Date: Mon, 17 Feb 2020 13:18:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 X-IsSubscribed: yes Hi. One obvious fix suggested by Andrew P. Martin gcc/ChangeLog: 2020-02-17 Martin Liska PR ipa/93760 * ipa-devirt.c (odr_types_equivalent_p): Fix grammar. gcc/testsuite/ChangeLog: 2020-02-17 Martin Liska PR ipa/93760 * g++.dg/lto/odr-8_1.C: Fix grammar. --- gcc/ipa-devirt.c | 2 +- gcc/testsuite/g++.dg/lto/odr-8_1.C | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c index b04cae704f9..bd9f3441773 100644 --- a/gcc/ipa-devirt.c +++ b/gcc/ipa-devirt.c @@ -1548,7 +1548,7 @@ odr_types_equivalent_p (tree t1, tree t2, bool warn, bool *warned, && COMPLETE_TYPE_P (t1) && COMPLETE_TYPE_P (t2)) { warn_odr (t1, t2, NULL, NULL, warn, warned, - G_("one type needs to be constructed while other not")); + G_("one type needs to be constructed while the other does not")); gcc_checking_assert (RECORD_OR_UNION_TYPE_P (t1)); return false; } diff --git a/gcc/testsuite/g++.dg/lto/odr-8_1.C b/gcc/testsuite/g++.dg/lto/odr-8_1.C index cbcd15d76ad..501dbbdd1b2 100644 --- a/gcc/testsuite/g++.dg/lto/odr-8_1.C +++ b/gcc/testsuite/g++.dg/lto/odr-8_1.C @@ -1,4 +1,4 @@ -struct a {char c; a() {} a(struct a &) {}}; // { dg-lto-message "one type needs to be constructed while other not" } +struct a {char c; a() {} a(struct a &) {}}; // { dg-lto-message "one type needs to be constructed while the other does not" } extern int test (struct a *a); int main()