diff mbox series

MIPS: Default to --with-llsc for the R5900 Linux target as well

Message ID a88a12af18ef1ac46173f8c581a74f0ca5da6704.1538807010.git.noring@nocrew.org
State New
Headers show
Series MIPS: Default to --with-llsc for the R5900 Linux target as well | expand

Commit Message

Fredrik Noring Oct. 6, 2018, 6:40 a.m. UTC 
The Linux kernel requires and emulates LL and SC for the R5900 too. The
special --without-llsc default for the R5900 is therefore not applicable
in that case.
---
 gcc/config.gcc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Maciej W. Rozycki Oct. 7, 2018, 7:37 p.m. UTC | #1 
Hi Fredrik,

> The Linux kernel requires and emulates LL and SC for the R5900 too. The

 Two spaces after a full stop please (in commit descriptions too).

> special --without-llsc default for the R5900 is therefore not applicable
> in that case.

 I cannot formally approve your change, but it looks good if not obviously
correct to me.  Therefore:

Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>

I hope this helps you get a general maintainer's approval.

 Also your change is small enough to be acceptable right away without a 
copyright assignment to FSF, however I do recommend that you make one for 
GCC as well (and also glibc and possibly GDB), as I imagine you'll come up 
with more changes as you progress with your effort.

 Thank you for your contribution!

  Maciej
Fredrik Noring Oct. 19, 2018, 6:33 p.m. UTC | #2 
Thank you for your review, Maciej,

> > The Linux kernel requires and emulates LL and SC for the R5900 too. The
> 
>  Two spaces after a full stop please (in commit descriptions too).

Fixed in v2, to be posted shortly.

> I hope this helps you get a general maintainer's approval.

Thanks! It looks like Matthew Fortune is the MIPS port maintainer, so I'm
cc'ing him on this patch.

>  Also your change is small enough to be acceptable right away without a 
> copyright assignment to FSF, however I do recommend that you make one for 
> GCC as well (and also glibc and possibly GDB), as I imagine you'll come up 
> with more changes as you progress with your effort.

Good, yes, I mentioned GCC when I posted the form to the FSF. Implementing
the -mfix-r5900 option is one such change. A small number of fixes related
to floating point instructions, MIPS16, etc. are also needed to make GCC
work with the R5900 target in a reasonable manner.

>  Thank you for your contribution!

You are welcome! :)

Fredrik
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 0c579d1f5ea..1fea2c0beaa 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -3709,14 +3709,14 @@  fi
 # Infer a default setting for --with-llsc.
 if test x$with_llsc = x; then
   case ${target} in
-    mips64r5900-*-* | mips64r5900el-*-* | mipsr5900-*-* | mipsr5900el-*-*)
-      # The R5900 doesn't support LL(D) and SC(D).
-      with_llsc=no
-      ;;
     mips*-*-linux*)
       # The kernel emulates LL and SC where necessary.
       with_llsc=yes
       ;;
+    mips64r5900-*-* | mips64r5900el-*-* | mipsr5900-*-* | mipsr5900el-*-*)
+      # The R5900 doesn't support LL(D) and SC(D).
+      with_llsc=no
+      ;;
   esac
 fi