diff mbox

[1/3] Error message on target attribute on power target (PR target/79906)

Message ID a77794cae689531edb908b7e2a4edcb193b12561.1489418416.git.mliska@suse.cz
State New
Headers show

Commit Message

Martin Liška March 13, 2017, 8:23 a.m. UTC 
gcc/ChangeLog:

2017-03-13  Martin Liska  <mliska@suse.cz>

	PR target/79906
	* config/rs6000/rs6000.c (rs6000_inner_target_options): Show
	error message instead of an ICE.

gcc/testsuite/ChangeLog:

2017-03-13  Martin Liska  <mliska@suse.cz>

	PR target/79906
	* g++.dg/ext/mv8.C: Add power* targets.
---
 gcc/config/rs6000/rs6000.c     | 5 ++++-
 gcc/testsuite/g++.dg/ext/mv8.C | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

Martin Liška March 21, 2017, 9:20 a.m. UTC | #1 
PING^ + adding power maintainer.

Thanks,
Martin
Segher Boessenkool March 21, 2017, 4:11 p.m. UTC | #2 
On Mon, Mar 13, 2017 at 09:23:51AM +0100, marxin wrote:
> gcc/ChangeLog:
> 
> 2017-03-13  Martin Liska  <mliska@suse.cz>
> 
> 	PR target/79906
> 	* config/rs6000/rs6000.c (rs6000_inner_target_options): Show
> 	error message instead of an ICE.
> 
> gcc/testsuite/ChangeLog:
> 
> 2017-03-13  Martin Liska  <mliska@suse.cz>
> 
> 	PR target/79906
> 	* g++.dg/ext/mv8.C: Add power* targets.

Okay, thanks!


Segher
diff mbox

Patch

diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index a1b58e21450..8bf5ee098dd 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -39204,7 +39204,10 @@  rs6000_inner_target_options (tree args, bool attr_p)
     }
 
   else
-    gcc_unreachable ();
+    {
+      error ("attribute %<target%> argument not a string");
+      return false;
+    }
 
   return ret;
 }
diff --git a/gcc/testsuite/g++.dg/ext/mv8.C b/gcc/testsuite/g++.dg/ext/mv8.C
index 2e98dd7ad85..bbf90b5a328 100644
--- a/gcc/testsuite/g++.dg/ext/mv8.C
+++ b/gcc/testsuite/g++.dg/ext/mv8.C
@@ -1,4 +1,4 @@ 
-// { dg-do compile { target i?86-*-* x86_64-*-* } }
+// { dg-do compile { target i?86-*-* x86_64-*-* powerpc*-*-* } }
 // { dg-options "" }
 
 __attribute__((target (11,12)))