From patchwork Tue Apr 16 07:42:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1924042 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A9RUJENd; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJbc72snlz1yZ2 for ; Tue, 16 Apr 2024 17:42:47 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C6BC385840E for ; Tue, 16 Apr 2024 07:42:45 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B0D7E3858D35 for ; Tue, 16 Apr 2024 07:42:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0D7E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0D7E3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713253342; cv=none; b=uEBcRdiHpfDYr066Ht8uwHR2F1o2ZvhCY/yzrmh9jSE/iX2A9tNzjM13NG+9daYtz0Qu+gaFS2jB5TGbRWFNNiWa2ItE+TWjwSJf2yKOmet3b1hmyNdbmFGEI7of7V2SQVRZa4HlBEas9LSqnmJB4H5okZG0nnL7g+t5lm6d89g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713253342; c=relaxed/simple; bh=+/UCNnLanzfJQpiHLgpxAl0jYGskQe2Bmp/oMPkRi3U=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=M26Hg3Gs40dvbB3W5bUUgqLRG9lLw+z22ejQUNpwOMifWU+nXz7EgRPhDMR73vsYeNFEtI17Dx6hoQIzf9jnniVF9AjP5K/J7F7lgW0X1lye4g8WU2UKx9T0nyTdqQs8o7UYQpst+Bhaj1mGqKWPLXoDPMZ2LahQ6a0DqbSMiV0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713253340; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=vWnV0o8cgUVrpkoT+JczC+YxlIaDRvQmbtBCqxA8uX8=; b=A9RUJENdcPTfZXdroq14Mler9lhduZV6UQBI3BSge0UnTUtc2plQldgxU5wRcUij6uBzPy 8+7hu6KMG/6M5kTD7A8bRFs9Ks5oHz1VaXXizG6XGlULJTuW1YCQN/BCGQnCLcQBOkoDct 3kK5BGaL8io5Z4ihMjIWSjc7Y+wmkQ8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-NO9LsX8WM5qclJ9NAu9asA-1; Tue, 16 Apr 2024 03:42:17 -0400 X-MC-Unique: NO9LsX8WM5qclJ9NAu9asA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BDC55806603; Tue, 16 Apr 2024 07:42:16 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 838E62166B32; Tue, 16 Apr 2024 07:42:16 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 43G7gBWM458975 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 09:42:11 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 43G7gA3N458974; Tue, 16 Apr 2024 09:42:10 +0200 Date: Tue, 16 Apr 2024 09:42:10 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix some comment nits Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi! While studying the TYPE_CANONICAL/TYPE_STRUCTURAL_EQUALITY_P stuff, I've noticed some nits in comments, the following patch fixes them. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2024-04-16 Jakub Jelinek * tree.cc (array_type_nelts): Ensure 2 spaces after . in comment instead of just one. (build_variant_type_copy): Likewise. (tree_check_failed): Likewise. (build_atomic_base): Likewise. * ipa-free-lang-data.cc (fld_incomplete_type_of): Use an indefinite article rather than a. Jakub --- gcc/tree.cc.jj 2024-04-15 14:25:21.721813546 +0200 +++ gcc/tree.cc 2024-04-15 17:49:25.923935286 +0200 @@ -3689,7 +3689,7 @@ int_byte_position (const_tree field) } /* Return, as a tree node, the number of elements for TYPE (which is an - ARRAY_TYPE) minus one. This counts only elements of the top array. */ + ARRAY_TYPE) minus one. This counts only elements of the top array. */ tree array_type_nelts (const_tree type) @@ -5757,7 +5757,7 @@ build_variant_type_copy (tree type MEM_S t = build_distinct_type_copy (type PASS_MEM_STAT); /* Since we're building a variant, assume that it is a non-semantic - variant. This also propagates TYPE_STRUCTURAL_EQUALITY_P. */ + variant. This also propagates TYPE_STRUCTURAL_EQUALITY_P. */ TYPE_CANONICAL (t) = TYPE_CANONICAL (type); /* Type variants have no alias set defined. */ TYPE_ALIAS_SET (t) = -1; @@ -8915,7 +8915,7 @@ get_file_function_name (const char *type #if defined ENABLE_TREE_CHECKING && (GCC_VERSION >= 2007) /* Complain that the tree code of NODE does not match the expected 0 - terminated list of trailing codes. The trailing code list can be + terminated list of trailing codes. The trailing code list can be empty, for a more vague error message. FILE, LINE, and FUNCTION are of the caller. */ @@ -9332,7 +9332,7 @@ make_or_reuse_accum_type (unsigned size, /* Create an atomic variant node for TYPE. This routine is called during initialization of data types to create the 5 basic atomic - types. The generic build_variant_type function requires these to + types. The generic build_variant_type function requires these to already be set up in order to function properly, so cannot be called from there. If ALIGN is non-zero, then ensure alignment is overridden to this value. */ --- gcc/ipa-free-lang-data.cc.jj 2024-04-15 14:25:21.668814259 +0200 +++ gcc/ipa-free-lang-data.cc 2024-04-15 17:49:47.303647823 +0200 @@ -234,7 +234,7 @@ fld_decl_context (tree ctx) return ctx; } -/* For T being aggregate type try to turn it into a incomplete variant. +/* For T being aggregate type try to turn it into an incomplete variant. Return T if no simplification is possible. */ static tree