From patchwork Fri Feb 9 09:44:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1896893 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hNbozL51; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TWTVJ2m9nz23h4 for ; Fri, 9 Feb 2024 20:45:12 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E319385841E for ; Fri, 9 Feb 2024 09:45:10 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B50913858C35 for ; Fri, 9 Feb 2024 09:44:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B50913858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B50913858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707471890; cv=none; b=uB5xZjGcwkiKucQLM+IlAgvnQBuGy8NI7OFPiY2aYvqpCCr0NARVT2lJJmwi4JeJ1//09RFCjGiUPGNhuViWGtwFBzY2jAsZ1pNx/CyccHnDO/pRGdgX3KzBtasikfy5U6FNL8G/HHy4r0zf0TKSAE/wnJKbm7vL+zA+gbQ1GkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707471890; c=relaxed/simple; bh=K931pRjNF0PbVcVKBdViZ99qEXiTZsHAOT0dEZEcg0M=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=kc1X8zP0EpCMdOUAshd6PKqSEQDKCC+EMJetmNsmdA5POXZ6VqeJD7/2oXMKtrV+dq8X9+RHtdnye5ZEt6cXMK4e91f50AeK9SZ7YC6LaDAnlNtkQc9T5AVdmlCi6TDV9xstUxC5wnl8WIKDAaJivEEDUkrKF49xy2DwRB5JMlg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707471888; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=KTownOenqXEvA7GNrc3HzzgyUYyIRCc22QmtTn5AAFw=; b=hNbozL51QwpsHhOnprv1sFUcMm6fVHqSeC7aD/TpbbR0ODsQ9M3s29/66tTk3szNUIYmzI CAKsCHcT6a43YcLsCMiwZ7bLP9aucFUKPioGgM19nezo8TXTGrdBz0uxxGpA8b3aX9X5X6 XBZrIeHTwxQA1hUxrmzu34AkVuhJtJk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-mD92JSQSOCO88eXyB4vrtA-1; Fri, 09 Feb 2024 04:44:46 -0500 X-MC-Unique: mD92JSQSOCO88eXyB4vrtA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27E9A85A58C; Fri, 9 Feb 2024 09:44:46 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFAAD2166B31; Fri, 9 Feb 2024 09:44:45 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 4199ihFw640138 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 9 Feb 2024 10:44:43 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 4199ig5x640137; Fri, 9 Feb 2024 10:44:42 +0100 Date: Fri, 9 Feb 2024 10:44:42 +0100 From: Jakub Jelinek To: Richard Biener , Jeff Law , Vladimir Makarov Cc: gcc-patches@gcc.gnu.org Subject: Patch ping Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi! I'd like to ping 2 patches: https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644580.html PR113617 P1 - Handle private COMDAT function symbol reference in readonly data section More details in the https://gcc.gnu.org/pipermail/gcc-patches/2024-January/thread.html#644121 and https://gcc.gnu.org/pipermail/gcc-patches/2024-January/thread.html#644486 threads. and https://gcc.gnu.org/pipermail/gcc-patches/2024-February/644701.html Introduce HOST_SIZE_T_PRINT_UNSIGNED etc. macros to fix LLP64 host build issue Both have been successfully bootstrapped/regtested on x86_64-linux and i686-linux, the latter has been tested by Jonathan on Windows too. The alternative is start using %zu (AFAIK we only do that in libgccjit which isn't supported everywhere and while it is C99, not sure if all supported host C libraries support it), or change ira-conflicts.cc to Note, we have many more cases where we use %ld or %lu to print size_t values (ideally %zd/%zu if we can assume it on all hosts, or with the above introduced HOST_SIZE_T_PRINT*, the problem with the %ld/%lu and casts is that it truncates the values on LLP64 hosts (aka %Windows). Jakub --- gcc/ira-conflicts.cc 2024-02-01 21:03:57.339193085 +0100 +++ gcc/ira-conflicts.cc 2024-02-09 10:41:39.201150644 +0100 @@ -151,8 +151,8 @@ build_conflict_bit_table (void) fprintf (ira_dump_file, "+++Allocating %ld bytes for conflict table (uncompressed size %ld)\n", - (long) allocated_words_num * sizeof (IRA_INT_TYPE), - (long) object_set_words * ira_objects_num * sizeof (IRA_INT_TYPE)); + (long) (allocated_words_num * sizeof (IRA_INT_TYPE)), + (long) (object_set_words * ira_objects_num * sizeof (IRA_INT_TYPE))); objects_live = sparseset_alloc (ira_objects_num); for (i = 0; i < ira_max_point; i++)