| Message ID | ZZ6tmE7EIRhURx91@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | aarch64: Make ldp/stp pass off by default | expand |
Alex Coplan <alex.coplan@arm.com> writes: > As discussed on IRC, this makes the aarch64 ldp/stp pass off by default. This > should stabilize the trunk and give some time to address the P1 regressions. > > Sorry for the breakage. > > Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk? > > Alex > > gcc/ChangeLog: > > * config/aarch64/aarch64.opt (-mearly-ldp-fusion): Set default > to 0. > (-mlate-ldp-fusion): Likewise. OK. Thanks for doing this, and for working through the PRs. Richard > diff --git a/gcc/config/aarch64/aarch64.opt b/gcc/config/aarch64/aarch64.opt > index ceed5cdb201..c495cb34fbf 100644 > --- a/gcc/config/aarch64/aarch64.opt > +++ b/gcc/config/aarch64/aarch64.opt > @@ -290,12 +290,12 @@ Target Var(aarch64_track_speculation) > Generate code to track when the CPU might be speculating incorrectly. > > mearly-ldp-fusion > -Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(1) > +Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(0) > Enable the copy of the AArch64 load/store pair fusion pass that runs before > register allocation. > > mlate-ldp-fusion > -Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(1) > +Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(0) > Enable the copy of the AArch64 load/store pair fusion pass that runs after > register allocation. >
On Wed, Jan 10, 2024 at 02:47:29PM +0000, Richard Sandiford wrote: > Alex Coplan <alex.coplan@arm.com> writes: > > As discussed on IRC, this makes the aarch64 ldp/stp pass off by default. This > > should stabilize the trunk and give some time to address the P1 regressions. > > > > Sorry for the breakage. > > > > Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk? > > > > Alex > > > > gcc/ChangeLog: > > > > * config/aarch64/aarch64.opt (-mearly-ldp-fusion): Set default > > to 0. > > (-mlate-ldp-fusion): Likewise. > > OK. Thanks for doing this, and for working through the PRs. Thanks. I'll repeat what I said on IRC, it is ok to reenable it say within 2-3 weeks if the fusion related P1s are addressed by then (or even earlier if it is addressed then). Jakub
diff --git a/gcc/config/aarch64/aarch64.opt b/gcc/config/aarch64/aarch64.opt index ceed5cdb201..c495cb34fbf 100644 --- a/gcc/config/aarch64/aarch64.opt +++ b/gcc/config/aarch64/aarch64.opt @@ -290,12 +290,12 @@ Target Var(aarch64_track_speculation) Generate code to track when the CPU might be speculating incorrectly. mearly-ldp-fusion -Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(1) +Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(0) Enable the copy of the AArch64 load/store pair fusion pass that runs before register allocation. mlate-ldp-fusion -Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(1) +Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(0) Enable the copy of the AArch64 load/store pair fusion pass that runs after register allocation.