diff mbox series

[committed] libgomp: Fix up target-31.c test [PR106045]

Message ID YrHq+YmyHuTqTvM0@tucnak
State New
Headers show
Series [committed] libgomp: Fix up target-31.c test [PR106045] | expand

Commit Message

Jakub Jelinek June 21, 2022, 3:59 p.m. UTC 
Hi!

The i variable is used inside of the parallel in:
      #pragma omp simd safelen(32) private (v)
      for (i = 0; i < 64; i++)
        {
          v = 3 * i;
          ll[i] = u1 + v * u2[0] + u2[1] + x + y[0] + y[1] + v + h[0] + u3[i];
        }
where i is predetermined linear (so while inside of the body
it is safe, private per SIMD lane var) the final value is written to
the shared variable, and in:
      for (i = 0; i < 64; i++)
        if (ll[i] != u1 + 3 * i * u2[0] + u2[1] + x + y[0] + y[1] + 3 * i + 13 + 14 + i)
          #pragma omp atomic write
            err = 1;
which is a normal loop and so it isn't in any way privatized there.
So we have a data race, fixed by adding private (i) clause to the
parallel.

Tested on x86_64-linux, committed to trunk.

2022-06-21  Jakub Jelinek  <jakub@redhat.com>
	    Paul Iannetta  <piannetta@kalrayinc.com>

	PR libgomp/106045
	* testsuite/libgomp.c/target-31.c: Add private (i) clause.



	Jakub
diff mbox series

Patch

--- libgomp/testsuite/libgomp.c/target-31.c.jj
+++ libgomp/testsuite/libgomp.c/target-31.c
@@ -76,7 +76,7 @@  main ()
       m[1] += 3 * b;
     }
     use (&a, &b, &c, &d, e, f, g, h);
-    #pragma omp parallel firstprivate (u1, u2)
+    #pragma omp parallel firstprivate (u1, u2) private (i)
     {
       int w = omp_get_thread_num ();
       int x = 19;