diff mbox series

cfg: Dump goto_locus if -fdump-*-*-blocks-details

Message ID Yh86/AnXVJpoV6yR@tucnak
State New
Headers show
Series cfg: Dump goto_locus if -fdump-*-*-blocks-details | expand

Commit Message

Jakub Jelinek March 2, 2022, 9:38 a.m. UTC
Hi!

When debugging the PR104589 issue, I've run into a problem that
goto_locus doesn't show up in the logs, so it wasn't clear if
the bug hasn't been introduced far earlier just by divergence
in goto_locus of some edge.

Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk,
or for GCC 13?

2022-03-02  Jakub Jelinek  <jakub@redhat.com>

	* cfg.cc (dump_edge_info): Dump goto_locus if present.


	Jakub

Comments

Richard Biener March 2, 2022, 9:45 a.m. UTC | #1
On Wed, 2 Mar 2022, Jakub Jelinek wrote:

> Hi!
> 
> When debugging the PR104589 issue, I've run into a problem that
> goto_locus doesn't show up in the logs, so it wasn't clear if
> the bug hasn't been introduced far earlier just by divergence
> in goto_locus of some edge.
> 
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk,
> or for GCC 13?

OK for trunk.

Richard.

> 2022-03-02  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* cfg.cc (dump_edge_info): Dump goto_locus if present.
> 
> --- gcc/cfg.cc.jj	2022-01-18 11:58:58.944991171 +0100
> +++ gcc/cfg.cc	2022-03-01 15:33:08.170217978 +0100
> @@ -555,6 +555,10 @@ dump_edge_info (FILE *file, edge e, dump
>  
>        fputc (')', file);
>      }
> +
> +  if (do_details && LOCATION_LOCUS (e->goto_locus) > BUILTINS_LOCATION)
> +    fprintf (file, " %s:%d:%d", LOCATION_FILE (e->goto_locus),
> +	     LOCATION_LINE (e->goto_locus), LOCATION_COLUMN (e->goto_locus));
>  }
>  
>  DEBUG_FUNCTION void
> 
> 	Jakub
> 
>
diff mbox series

Patch

--- gcc/cfg.cc.jj	2022-01-18 11:58:58.944991171 +0100
+++ gcc/cfg.cc	2022-03-01 15:33:08.170217978 +0100
@@ -555,6 +555,10 @@  dump_edge_info (FILE *file, edge e, dump
 
       fputc (')', file);
     }
+
+  if (do_details && LOCATION_LOCUS (e->goto_locus) > BUILTINS_LOCATION)
+    fprintf (file, " %s:%d:%d", LOCATION_FILE (e->goto_locus),
+	     LOCATION_LINE (e->goto_locus), LOCATION_COLUMN (e->goto_locus));
 }
 
 DEBUG_FUNCTION void