diff mbox series

c++: Do not warn about lifetime of std::initializer_list<T>& [PR102482]

Message ID YVd2bMMgZtEVITN1@redhat.com
State New
Headers show
Series c++: Do not warn about lifetime of std::initializer_list<T>& [PR102482] | expand

Commit Message

Jonathan Wakely Oct. 1, 2021, 8:58 p.m. UTC 
An initializer-list constructor taking a non-const lvalue cannot be
called with a temporary, so the array's lifetime probably doesn't end
with the full expression. -Winit-list-lifetime should not warn for that
case.

	PR c++/102482

gcc/cp/ChangeLog:

	* init.c (maybe_warn_list_ctor): Do not warn for a reference to
	a non-const std::initializer_list.

gcc/testsuite/ChangeLog:

	* g++.dg/warn/Winit-list5.C: New test.



Tested x86_64-linux. OK for trunk?
commit 474f2ae9c9f8312d9c732094bfb1c8da7342d6a9
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Sep 29 21:19:49 2021

    c++: Do not warn about lifetime of std::initializer_list<T>& [PR102482]
    
    An initializer-list constructor taking a non-const lvalue cannot be
    called with a temporary, so the array's lifetime probably doesn't end
    with the full expression. -Winit-list-lifetime should not warn for that
    case.
    
            PR c++/102482
    
    gcc/cp/ChangeLog:
    
            * init.c (maybe_warn_list_ctor): Do not warn for a reference to
            a non-const std::initializer_list.
    
    gcc/testsuite/ChangeLog:
    
            * g++.dg/warn/Winit-list5.C: New test.

Comments

Jason Merrill Oct. 6, 2021, 11:49 p.m. UTC | #1 
On 10/1/21 16:58, Jonathan Wakely wrote:
> An initializer-list constructor taking a non-const lvalue cannot be
> called with a temporary, so the array's lifetime probably doesn't end
> with the full expression. -Winit-list-lifetime should not warn for that
> case.
> 
> 	PR c++/102482
> 
> gcc/cp/ChangeLog:
> 
> 	* init.c (maybe_warn_list_ctor): Do not warn for a reference to
> 	a non-const std::initializer_list.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* g++.dg/warn/Winit-list5.C: New test.
> 
> 
> 
> Tested x86_64-linux. OK for trunk?

OK, thanks.

Jason
diff mbox series

Patch

diff --git a/gcc/cp/init.c b/gcc/cp/init.c
index 1426f9a5434..771a19bc402 100644
--- a/gcc/cp/init.c
+++ b/gcc/cp/init.c
@@ -749,8 +749,15 @@  maybe_warn_list_ctor (tree member, tree init)
       || !is_list_ctor (current_function_decl))
     return;
 
-  tree parms = FUNCTION_FIRST_USER_PARMTYPE (current_function_decl);
-  tree initlist = non_reference (TREE_VALUE (parms));
+  tree parm = FUNCTION_FIRST_USER_PARMTYPE (current_function_decl);
+  parm = TREE_VALUE (parm);
+  tree initlist = non_reference (parm);
+
+  /* Do not warn if the parameter is an lvalue reference to non-const.  */
+  if (TYPE_REF_P (parm) && !TYPE_REF_IS_RVALUE (parm)
+      && !CP_TYPE_CONST_P (initlist))
+    return;
+
   tree targs = CLASSTYPE_TI_ARGS (initlist);
   tree elttype = TREE_VEC_ELT (targs, 0);
 
diff --git a/gcc/testsuite/g++.dg/warn/Winit-list5.C b/gcc/testsuite/g++.dg/warn/Winit-list5.C
new file mode 100644
index 00000000000..07b3a69e46b
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Winit-list5.C
@@ -0,0 +1,61 @@ 
+// PR c++/102482
+// { dg-do compile { target c++11 } }
+// Test we don't warn for non-const lvalue refs.
+
+#include <initializer_list>
+
+struct X { };
+
+struct span
+{
+  span(std::initializer_list<int>& il)
+  : begin(il.begin()) // { dg-bogus "initializer_list" }
+  { }
+
+  const int* begin;
+};
+
+struct span_warn
+{
+  span_warn(std::initializer_list<int> il)
+  : begin(il.begin()) // { dg-warning "initializer_list" }
+  { }
+
+  const int* begin;
+};
+
+struct span_warn2
+{
+  span_warn2(std::initializer_list<int>&& il)
+  : begin(il.begin()) // { dg-warning "initializer_list" }
+  { }
+
+  const int* begin;
+};
+
+struct span_warn3
+{
+  span_warn3(std::initializer_list<int> const& il)
+  : begin(il.begin()) // { dg-warning "initializer_list" }
+  { }
+
+  const int* begin;
+};
+
+struct span_warn4
+{
+  span_warn4(std::initializer_list<int> const il)
+  : begin(il.begin()) // { dg-warning "initializer_list" }
+  { }
+
+  const int* begin;
+};
+
+struct span_warn5
+{
+  span_warn5(std::initializer_list<int> const&& il)
+  : begin(il.begin()) // { dg-warning "initializer_list" }
+  { }
+
+  const int* begin;
+};