| Message ID | YHhjKF1kt0XllY4R@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | libstdc++: Add -latomic to test flags for 32-bit sparc-linux | expand |
> Without this I see a number of tests failing when -m32 is used. > > libstdc++-v3/ChangeLog: > > * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also > add libatomic options for 32-bit sparc*-*-linux-gnu. > > Eric, are you OK with this? It adds -latomic and the appropriate -L > options to tests that use { dg-add-options libatomic }, because > sparcv8 needs libatomic for some std::atomic ops. Sure, thanks.
On 15/04/21 18:23 +0200, Eric Botcazou wrote: >> Without this I see a number of tests failing when -m32 is used. >> >> libstdc++-v3/ChangeLog: >> >> * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also >> add libatomic options for 32-bit sparc*-*-linux-gnu. >> >> Eric, are you OK with this? It adds -latomic and the appropriate -L >> options to tests that use { dg-add-options libatomic }, because >> sparcv8 needs libatomic for some std::atomic ops. > >Sure, thanks. Thanks, pushed to trunk.
diff --git a/libstdc++-v3/testsuite/lib/dg-options.exp b/libstdc++-v3/testsuite/lib/dg-options.exp index 5160e4a72d1..7894973bcca 100644 --- a/libstdc++-v3/testsuite/lib/dg-options.exp +++ b/libstdc++-v3/testsuite/lib/dg-options.exp @@ -264,6 +264,7 @@ proc add_options_for_libatomic { flags } { if { [istarget hppa*-*-hpux*] || ([istarget powerpc*-*-*] && [check_effective_target_ilp32]) || [istarget riscv*-*-*] + || ([istarget sparc*-*-linux-gnu] && [check_effective_target_ilp32]) } { return "$flags -L../../libatomic/.libs -latomic" }
Without this I see a number of tests failing when -m32 is used. libstdc++-v3/ChangeLog: * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also add libatomic options for 32-bit sparc*-*-linux-gnu. Eric, are you OK with this? It adds -latomic and the appropriate -L options to tests that use { dg-add-options libatomic }, because sparcv8 needs libatomic for some std::atomic ops. commit bbee87be3bfaa1ef19521870df998386f83d7ac2 Author: Jonathan Wakely <jwakely@redhat.com> Date: Thu Apr 15 16:39:55 2021 libstdc++: Add -latomic to test flags for 32-bit sparc-linux Without this I see a number of tests failing when -m32 is used. libstdc++-v3/ChangeLog: * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also add libatomic options for 32-bit sparc*-*-linux-gnu.