| Message ID | Y29erF8D0T/tXav0@tucnak |
|---|---|
| State | New |
| Headers | show |
| Series | [committed] libgomp: Fix up build on mingw [PR107641] | expand |
--- libgomp/env.c.jj 2022-09-13 18:59:52.331054977 +0200 +++ libgomp/env.c 2022-11-11 18:10:21.552415182 +0100 @@ -283,7 +283,7 @@ parse_unsigned_long_1 (const char *env, static bool parse_unsigned_long (const char *env, const char *val, void *const params[]) { - unsigned upper = (unsigned long) params[2]; + unsigned long upper = (uintptr_t) params[2]; unsigned long pvalue = 0; bool ret = parse_unsigned_long_1 (env, val, &pvalue, (bool) params[1]); if (!ret)
Hi! Pointers should be first casted to intptr_t/uintptr_t before casting them to another integral type to avoid warnings. Furthermore, the function has code like else if (upper <= UINT_MAX) something; else something_else; so it seems using unsigned type for upper where upper <= UINT_MAX is always true is not intended. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2022-11-12 Jakub Jelinek <jakub@redhat.com> PR libgomp/107641 * env.c (parse_unsigned_long): Cast params[2] to uintptr_t rather than unsigned long. Change type of upper from unsigned to unsigned long. Jakub