diff mbox series

AArch32: fix bootstrap failure

Message ID VI1PR08MB40296621586616C6B680566FEAA50@VI1PR08MB4029.eurprd08.prod.outlook.com
State New
Headers show
Series AArch32: fix bootstrap failure | expand

Commit Message

Alex Coplan May 7, 2020, 10:30 a.m. UTC
Hello,

The attached patch fixes a bootstrap failure on AArch32 introduced by
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=308bc496884706af4b3077171cbac684c7a6f7c6

This makes the declaration of arm_add_stmt_cost match the definition, and removes the redundant
class keyword from the definition.

Testing:
  * Bootstrap on arm-linux-gnueabihf.

Thanks,
Alex

---

gcc/ChangeLog:

2020-05-07  Alex Coplan  <alex.coplan@arm.com>

        * config/arm/arm.c (arm_add_stmt_cost): Fix declaration, remove class from definition.

Comments

Kyrylo Tkachov May 7, 2020, 10:36 a.m. UTC | #1
Hi Alex,

> -----Original Message-----
> From: Alex Coplan <Alex.Coplan@arm.com>
> Sent: 07 May 2020 11:31
> To: gcc-patches@gcc.gnu.org
> Cc: nickc@redhat.com; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>; Kyrylo
> Tkachov <Kyrylo.Tkachov@arm.com>; nd <nd@arm.com>
> Subject: AArch32: fix bootstrap failure
> 
> Hello,
> 
> The attached patch fixes a bootstrap failure on AArch32 introduced by
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=308bc496884706af4b3077171
> cbac684c7a6f7c6
> 
> This makes the declaration of arm_add_stmt_cost match the definition, and
> removes the redundant
> class keyword from the definition.

Thanks, I've pushed this patch to master.
Kyrill

> 
> Testing:
>   * Bootstrap on arm-linux-gnueabihf.
> 
> Thanks,
> Alex
> 
> ---
> 
> gcc/ChangeLog:
> 
> 2020-05-07  Alex Coplan  <alex.coplan@arm.com>
> 
>         * config/arm/arm.c (arm_add_stmt_cost): Fix declaration, remove class
> from definition.

I've fixed up the line length (it should be below 80 columns)
diff mbox series

Patch

diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index bbd7dc5316c..d50781953c0 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -306,7 +306,7 @@  static bool aarch_macro_fusion_pair_p (rtx_insn*, rtx_insn*);
 static int arm_builtin_vectorization_cost (enum vect_cost_for_stmt type_of_cost,
 					   tree vectype,
 					   int misalign ATTRIBUTE_UNUSED);
-static unsigned arm_add_stmt_cost (void *data, int count,
+static unsigned arm_add_stmt_cost (vec_info *vinfo, void *data, int count,
 				   enum vect_cost_for_stmt kind,
 				   struct _stmt_vec_info *stmt_info,
 				   int misalign,
@@ -12131,7 +12131,7 @@  arm_builtin_vectorization_cost (enum vect_cost_for_stmt type_of_cost,
 /* Implement targetm.vectorize.add_stmt_cost.  */
 
 static unsigned
-arm_add_stmt_cost (class vec_info *vinfo, void *data, int count,
+arm_add_stmt_cost (vec_info *vinfo, void *data, int count,
 		   enum vect_cost_for_stmt kind,
 		   struct _stmt_vec_info *stmt_info, int misalign,
 		   enum vect_cost_model_location where)