From patchwork Wed Mar 9 03:33:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 594822 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9B6C91402C9 for ; Wed, 9 Mar 2016 14:34:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Cr+1vK9S; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; q=dns; s=default; b=doiOk6LREZtmKTGfKuzsxwWgh4j8fJ/jzMeQtjN6M7J+bhAVXJ qaUNPu5dfk/5aCdWDQJ/PG4w5Xn3YU8/Oarvbq/eWgjKDbWkV0FylxrQJH+BUnIe 8UG78/hpdKeLxtuE58nW2QDZ0jM9Ap8UIl6xQWV+cHeI4R9f1Gw+Rc9Cs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; s= default; bh=sbHVIeMUt10X0Wlhz1I4l/G6R+I=; b=Cr+1vK9SlSaLOxZNIbio BqjdMZUCH7/zWKLyMq/159dSLGcvvOK9WlVX2bb3wUNndMKQVFvYXhGKm5k/bh5o 7tq4Q80UTrCLbR23DKGNJTGO7de0V668tKBMrgOkOVQ9nzyRY0/DvAl2CRMW3lFj wugP19kZpsv0GV8WWrles/A= Received: (qmail 56632 invoked by alias); 9 Mar 2016 03:34:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 55035 invoked by uid 89); 9 Mar 2016 03:34:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_05, FREEMAIL_FROM, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 spammy=Hx-exchange-antispam-report-cfa-test:102415293, Hx-exchange-antispam-report-cfa-test:102615271, H*MI:eurprd07, H*M:eurprd07 X-Spam-User: qpsmtpd, 2 recipients X-HELO: DUB004-OMC4S2.hotmail.com Received: from dub004-omc4s2.hotmail.com (HELO DUB004-OMC4S2.hotmail.com) (157.55.2.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Wed, 09 Mar 2016 03:33:54 +0000 Received: from emea01-db3-obe.outbound.protection.outlook.com ([157.55.2.73]) by DUB004-OMC4S2.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Tue, 8 Mar 2016 19:33:50 -0800 Received: from VI1PR07MB0911.eurprd07.prod.outlook.com (10.161.109.11) by VI1PR07MB0909.eurprd07.prod.outlook.com (10.161.108.27) with Microsoft SMTP Server (TLS) id 15.1.415.20; Wed, 9 Mar 2016 03:33:50 +0000 Received: from VI1PR07MB0911.eurprd07.prod.outlook.com ([10.161.109.11]) by VI1PR07MB0911.eurprd07.prod.outlook.com ([10.161.109.11]) with mapi id 15.01.0415.025; Wed, 9 Mar 2016 03:33:50 +0000 From: Bernd Edlinger To: "gcc-patches@gcc.gnu.org" , "libstdc++@gcc.gnu.org" CC: Jonathan Wakely Subject: [PATCH, libstdc++] Add missing free-standing headers to install rule Date: Wed, 9 Mar 2016 03:33:50 +0000 Message-ID: authentication-results: redhat.com; dkim=none (message not signed) header.d=none; redhat.com; dmarc=none action=none header.from=hotmail.de; x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [m1Ita8HWkAaE+cJa9qMD6vSxKNkKISd/] x-microsoft-exchange-diagnostics: 1; VI1PR07MB0909; 23:zgUzG6Ak0rhxv4G1o8wMVa4t1eNDprRjRvJEOdsEDERlrPN6ZQdioCqmiLqwVOmoyjF939EggPCQ0mjjokyOBWv5S31z1Gg48WNCfPgOwm5a2riwmlgaKJF3UFb+kLThIS/XqZZaoEcZj+d8mJo6soyyFcuwMABoc60jnJOPG5I8Y1/nCGor6VhvoJawTpKebX/LGos8xgOBdinmLuoKIQ==; 5:y17jiNu6nNTrZRptiE/omwChHjb5ZegMnGSi9fOV6WstyvMa/bbjqwCyr1QlRaDTfb9J97UTp9/k4K9n7LHx/2pGqAfry32YI9LAHghC0TlekIaGw3WAHnPJQykISaNiZGGDiS1nHoCaDAFmFXWmNw==; 24:QytnECT1g+6YpNT6a+Kfa+A1tdDJXF0gM7GugAwziL631i1sUwjxCCrnu8XtO0pJRyoyl0V2nR919KSvBYlQ6HV8zJ4heeF0lDLQoS0bc5I= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR07MB0909; x-ms-office365-filtering-correlation-id: 3811607c-4b08-423b-05eb-08d347cba179 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015012)(102415293)(102615271)(82015046); SRVR:VI1PR07MB0909; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB0909; x-forefront-prvs: 0876988AF0 x-forefront-antispam-report: SFV:NSPM; SFS:(7070004)(98900003); DIR:OUT; SFP:1901; SCL:1; SRVR:VI1PR07MB0909; H:VI1PR07MB0911.eurprd07.prod.outlook.com; FPR:; SPF:None; MLV:ovrnspm; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: sct-15-1-409-10-msonline-outlook-d6129.templateTenant X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2016 03:33:50.1430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB0909 Hi, when the free-standing libstdc++-headers are installed, the C++ header file does not always compile, because it includes and this includes under certain conditions (__cplusplus >= 201103L && ATOMIC_INT_LOCK_FREE > 1) the header file but that fails to compile because it needs which is not installed. This condition depends on the target, and for instance an arm-eabi eCos compiler fails to compile with -mcpu=cortex-a9 and the default C++ standard option, while it is OK with ARMv4 CPUs. Therefore this patch adds move.h and concept_check.h to the installed headers, unconditionally. I've verified that the header compiles on an eCos cross compiler. Boot-strapped and regression-tested on x86_64-pc-linux-gnu. Is it OK for trunk? Thanks Bernd. 2016-03-08 Bernd Edlinger * include/Makefile.am (install-freestanding-headers): Add concept_check.h and move.h to the installed headers. * include/Makefile.in: Regenerated. Index: libstdc++-v3/include/Makefile.am =================================================================== --- libstdc++-v3/include/Makefile.am (revision 234060) +++ libstdc++-v3/include/Makefile.am (working copy) @@ -1331,7 +1331,7 @@ # libsupc++, so only the others and the sub-includes are copied here. install-freestanding-headers: $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/bits - for file in c++0x_warning.h atomic_base.h; do \ + for file in c++0x_warning.h atomic_base.h concept_check.h move.h; do \ $(INSTALL_DATA) ${glibcxx_srcdir}/include/bits/$${file} $(DESTDIR)${gxx_include_dir}/bits; done $(mkinstalldirs) $(DESTDIR)${host_installdir} for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \ Index: libstdc++-v3/include/Makefile.in =================================================================== --- libstdc++-v3/include/Makefile.in (revision 234060) +++ libstdc++-v3/include/Makefile.in (working copy) @@ -1753,7 +1753,7 @@ # libsupc++, so only the others and the sub-includes are copied here. install-freestanding-headers: $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/bits - for file in c++0x_warning.h atomic_base.h; do \ + for file in c++0x_warning.h atomic_base.h concept_check.h move.h; do \ $(INSTALL_DATA) ${glibcxx_srcdir}/include/bits/$${file} $(DESTDIR)${gxx_include_dir}/bits; done $(mkinstalldirs) $(DESTDIR)${host_installdir} for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \