From patchwork Fri Aug 26 12:34:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Matz X-Patchwork-Id: 111762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8C1E3B6F80 for ; Fri, 26 Aug 2011 22:34:50 +1000 (EST) Received: (qmail 8885 invoked by alias); 26 Aug 2011 12:34:47 -0000 Received: (qmail 8643 invoked by uid 22791); 26 Aug 2011 12:34:46 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, TW_CP X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 12:34:31 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 606BF8F0A5; Fri, 26 Aug 2011 14:34:30 +0200 (CEST) Date: Fri, 26 Aug 2011 14:34:29 +0200 (CEST) From: Michael Matz To: Richard Guenther Cc: Richard Guenther , Diego Novillo , reply@codereview.appspotmail.com, jh@suse.cz, gcc-patches@gcc.gnu.org Subject: Re: [lto] Refactor streamer (1/N) (issue4809083) In-Reply-To: Message-ID: References: <20110808142334.C690B1DA1B5@topo.tor.corp.google.com> MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, On Fri, 26 Aug 2011, Richard Guenther wrote: > >> I am going to be sending the renaming patch later today or tomorrow. > >> In principle, the things I want to abstract are those that are > >> forcing me to include lto-streamer.h from > >> {tree,gimple,data}-streamer.*. I will know better when I merge this > >> into the pph branch, though. > > > > Yeah, I think we discussed this already and agreed on that this is a > > sensible plan. > > This patch caused http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50165 it > seems that LTO string hashing is seriously broken now. Once regstrap passes on x86_64-linux I'm checking this in as obvious. Ciao, Michael. Index: lto-streamer-in.c =================================================================== --- lto-streamer-in.c (revision 178040) +++ lto-streamer-in.c (working copy) @@ -113,6 +113,7 @@ canon_file_name (const char *string) new_slot = XCNEW (struct string_slot); strcpy (saved_string, string); new_slot->s = saved_string; + new_slot->len = len; *slot = new_slot; return saved_string; }