From patchwork Thu Sep 1 07:31:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Rosen X-Patchwork-Id: 112828 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 62B5CB6F7B for ; Thu, 1 Sep 2011 17:31:40 +1000 (EST) Received: (qmail 9020 invoked by alias); 1 Sep 2011 07:31:36 -0000 Received: (qmail 9010 invoked by uid 22791); 1 Sep 2011 07:31:35 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Sep 2011 07:31:20 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p817VI3q025856 for ; Thu, 1 Sep 2011 07:31:18 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p817VIFH2502760 for ; Thu, 1 Sep 2011 08:31:18 +0100 Received: from d06av07.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p817VHrl017684 for ; Thu, 1 Sep 2011 01:31:17 -0600 Received: from d12mc102.megacenter.de.ibm.com (d12mc102.megacenter.de.ibm.com [9.149.167.114]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p817VHb8017673; Thu, 1 Sep 2011 01:31:17 -0600 In-Reply-To: References: Subject: Re: [PATCH] Make vectorizer dumps more comparable X-KeepSent: 81FD7184:88F3B5C4-C22578FE:0028D474; type=4; name=$KeepSent To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Message-ID: From: Ira Rosen Date: Thu, 1 Sep 2011 10:31:15 +0300 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org gcc-patches-owner@gcc.gnu.org wrote on 24/08/2011 02:20:50 PM: > > This avoids the file/location clutter in front of each line > in the vectorizer dump. While this is useful for people > requesting -fvectorizer-verbose=N in dump files this makes > you unable to compare dumps for testcases on a branch and trunk. > It also makes lines excessively long because the testsuite > filename paths are so long. Very annoying. > > (I'd argue also that -fvectorizer-verbose=N dumps to the dump > file if available and not always to stderr is bogus, but well ...) > > This patch has made my life a lot easier debugging the data dependence > stuff. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, installed on trunk. > > Richard. > > 2011-08-24 Richard Guenther > > * tree-vectorizer.c (vect_print_dump_info): Avoid the > file and location clutter when dumping to dump files. IMO it's a bad idea. It's now impossible to find anything when compiling a big file. How about only removing the file name? Ira > > Index: gcc/tree-vectorizer.c > =================================================================== > --- gcc/tree-vectorizer.c (revision 178028) > +++ gcc/tree-vectorizer.c (working copy) > @@ -149,7 +149,10 @@ vect_print_dump_info (enum vect_verbosit > if (!current_function_decl || !vect_dump) > return false; > > - if (vect_location == UNKNOWN_LOC) > + if (dump_file) > + fprintf (vect_dump, "\n"); > + > + else if (vect_location == UNKNOWN_LOC) > fprintf (vect_dump, "\n%s:%d: note: ", > DECL_SOURCE_FILE (current_function_decl), > DECL_SOURCE_LINE (current_function_decl)); > Index: tree-vectorizer.c =================================================================== --- tree-vectorizer.c (revision 178374) +++ tree-vectorizer.c (working copy) @@ -149,16 +149,12 @@ vect_print_dump_info (enum vect_verbosit if (!current_function_decl || !vect_dump) return false; - if (dump_file) - fprintf (vect_dump, "\n"); - - else if (vect_location == UNKNOWN_LOC) - fprintf (vect_dump, "\n%s:%d: note: ", - DECL_SOURCE_FILE (current_function_decl), + if (vect_location == UNKNOWN_LOC) + fprintf (vect_dump, "\nline %d: ", DECL_SOURCE_LINE (current_function_decl)); else - fprintf (vect_dump, "\n%s:%d: note: ", - LOC_FILE (vect_location), LOC_LINE (vect_location)); + fprintf (vect_dump, "\nline %d: ", + LOC_LINE (vect_location)); return true; }