From patchwork Tue Nov 26 15:17:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 1201104 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-514616-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="hKjqYMFD"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="1QmMIAAn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="1QmMIAAn"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47MnbS0wsrz9sPV for ; Wed, 27 Nov 2019 02:18:09 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=Jwa 9OxX1UOffUs+a2iWpuOLv+a1AgOilhaE6sfvze2pBofXdliaN55JzGRVoNFwlktV dSykwFFhvo+eN+YH65OI7ycGfqzL2+IJyxCR1lmD29EmlPz/BDQN33VNj1qTiWlP cnAMu/6nxFbvhS8/fPHMmAw4Lmp8y3fuPWPl51UM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=akHKPI36r 8o8OWJqFtNrh2AUfk4=; b=hKjqYMFDEGbPTFMrDnkKQGrJDe3A/YzEhKD+9RndC ej+b4TIlfdNIgORWQ+0TPe3WVymgzu4LBw99my13hbv7zca7nUDNRBj+gmpqBXG/ dLSlXLwxqSlpGhlp50FZs8CxwZ7nVCVH/QzkXreR+Na30R1S7u68u3OaH/l11bkc j4= Received: (qmail 59950 invoked by alias); 26 Nov 2019 15:18:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 59940 invoked by uid 89); 26 Nov 2019 15:18:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.5 required=5.0 tests=AWL, BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70085.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 15:18:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNwU7kvQxru0cLwwKogtkUSwwGHnlorgqjL59vr/kOc=; b=1QmMIAAnAI4zXCd8x9KMk4bstpGMiYWVoLQo08uft62BF1e8RzTj5KpCO2j7FXKao1/rNcYevRHEHLWDJaNvAVGi4Wn2JZ6I65sVui/Hq60iarEDoF1F19pVgI40vrPyVXt8vVqQSrlG7SfsZJc37E4+16QK9yLIfvZ0S7a16ng= Received: from VI1PR08CA0146.eurprd08.prod.outlook.com (2603:10a6:800:d5::24) by DB7PR08MB3434.eurprd08.prod.outlook.com (2603:10a6:10:42::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.16; Tue, 26 Nov 2019 15:17:57 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::209) by VI1PR08CA0146.outlook.office365.com (2603:10a6:800:d5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17 via Frontend Transport; Tue, 26 Nov 2019 15:17:57 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17 via Frontend Transport; Tue, 26 Nov 2019 15:17:55 +0000 Received: ("Tessian outbound dbe0f0961e8c:v33"); Tue, 26 Nov 2019 15:17:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f46bc174801d4c25 X-CR-MTA-TID: 64aa7808 Received: from 94d0363a426c.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.2.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBB3ACFD-4AF1-40BC-B104-602C12FC0FE5.1; Tue, 26 Nov 2019 15:17:49 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 94d0363a426c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Nov 2019 15:17:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I+Chi+p7tSFGrsXvoptZZ28CK5oeGiVxcMLiBHTwX+1F2G+s3m2BQA+OXIxi/KlFEEzrgF/cUF2Rts1uod7sYY7CeUYk5Edh9bFiF5tdSc2ndacm/YEbU3/nnShtaetIwQocJ/VIEk1u4NwdVRrJ0k97V9PPDm4k42g/uPJYQqjUNSdCWPntj6GxI4XQj4E8yaEEG15IYf30BtMx8pZgfAUNNK/6Jd0Sf0tOmcW0h6kN83Dl9lAEWCBQWintIdSkTmGkHI6stqDYK+q1TxmoQ5ZZ5Z+VieYwN0yVTy1/aLpA5wxkuOPT+YVjxUPCIuqXESZ5Yuf2FI9WEp1/0464KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNwU7kvQxru0cLwwKogtkUSwwGHnlorgqjL59vr/kOc=; b=BGLgfVT0G58dEEifrdyh9OCf4AGm3v2MEUdJ+SsAw7KWPoYrlrOSD5n6dKhQB3jXAo3PN/5+0Fw+n2ei894B86eu46bZxSYEOXgmKNxRWQuftDLB0roEEYMEbHdTiRvezupt2BsY3vW6iUTx/zMgCaaYSbhTOf27qCni74mZr7MVOd66D7dTjsanhdl/mzh1Agq+riyorGsxjbQPKPbv1yWBIYNg3rxjcmEDSS1qta7rRHRZlzlmXE9S5ARrAYpSQxBIxI7CWINzstDlMsVFEawBIp1Cu1V3r661ZPWPb8jJnB4dCeHdbUCzC7CBlwj6PdlhNoI5PdUFXj8EP3uNlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNwU7kvQxru0cLwwKogtkUSwwGHnlorgqjL59vr/kOc=; b=1QmMIAAnAI4zXCd8x9KMk4bstpGMiYWVoLQo08uft62BF1e8RzTj5KpCO2j7FXKao1/rNcYevRHEHLWDJaNvAVGi4Wn2JZ6I65sVui/Hq60iarEDoF1F19pVgI40vrPyVXt8vVqQSrlG7SfsZJc37E4+16QK9yLIfvZ0S7a16ng= Received: from HE1PR0801MB2121.eurprd08.prod.outlook.com (10.168.146.10) by HE1PR0801MB1867.eurprd08.prod.outlook.com (10.168.96.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Tue, 26 Nov 2019 15:17:48 +0000 Received: from HE1PR0801MB2121.eurprd08.prod.outlook.com ([fe80::75c3:f204:3444:b4c2]) by HE1PR0801MB2121.eurprd08.prod.outlook.com ([fe80::75c3:f204:3444:b4c2%3]) with mapi id 15.20.2474.023; Tue, 26 Nov 2019 15:17:47 +0000 From: Wilco Dijkstra To: GCC Patches CC: Kyrylo Tkachov , Richard Earnshaw , Richard Sandiford Subject: [PATCH v2][ARM] Disable code hoisting with -O3 (PR80155) Date: Tue, 26 Nov 2019 15:17:47 +0000 Message-ID: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:862;OLM:862; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(54534003)(199004)(189003)(186003)(26005)(6506007)(8936002)(86362001)(6116002)(99286004)(25786009)(52536014)(7736002)(74316002)(305945005)(256004)(4001150100001)(7696005)(81166006)(102836004)(81156014)(54906003)(316002)(8676002)(14454004)(2906002)(76116006)(64756008)(66446008)(478600001)(33656002)(66476007)(66556008)(66946007)(66066001)(5660300002)(6436002)(4326008)(55016002)(3846002)(71190400001)(71200400001)(6916009)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1867; H:HE1PR0801MB2121.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PHYVL0lVfTstVcmfLDky5IUiDexhwmgU0oMkemq8kVs+cHHkn3dsPT4n2czG19ucqj0kZ5Tc6ubzTp0059GPOde/DTAt01hHr8br0Y6A0tPkeOG/jc/SSf2EkA3NUOx/saI40XfGoI4HVVFiQtd98CgNhEs71+bfyKDxho6RXv05WizMLQpS/aaggOWKhF9+5zO474wz9AO3Qg8tjLxtsQ0nDsNAqPHoU3hGxNz+wBqGShIAfTWn8Vbtf4QkH41mQzqdOq1YrRHDl8WFKJAVg2ndoSNCNKZFzLnZDm9vj+sWUe7ghqd89jiOupl9qhjmXUe0oBT3b9VHRPailmrGjWgE5BdK9DasXZ9MjFcRFtTIe8tPnPAYUuyQutLEibJ2805/6whyTwwIiGM+VvXtlRLZK/vDmXhyzKxJeSDUCSZC3i9Q5n7tET6vJQG2/iVR MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cdc05201-9d99-4e5c-cac0-08d77283cb9c Hi, While code hoisting generally improves codesize, it can affect performance negatively. Benchmarking shows it doesn't help SPEC and negatively affects embedded benchmarks. Since the impact is relatively small with -O2 and mainly affects -O3, the simplest option is to disable code hoisting for -O3 and higher. OK for commit? ChangeLog: 2019-11-26 Wilco Dijkstra PR tree-optimization/80155 * common/config/arm/arm-common.c (arm_option_optimization_table): Disable -fcode-hoisting with -O3. diff --git a/gcc/common/config/arm/arm-common.c b/gcc/common/config/arm/arm-common.c index b761d3abd670a144a593c4b410b1e7fbdcb52f56..3e11f21b7dd76cc071b645c32a6fdb4a92511279 100644 --- a/gcc/common/config/arm/arm-common.c +++ b/gcc/common/config/arm/arm-common.c @@ -39,6 +39,8 @@ static const struct default_options arm_option_optimization_table[] = /* Enable section anchors by default at -O1 or higher. */ { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 }, { OPT_LEVELS_FAST, OPT_fsched_pressure, NULL, 1 }, + /* Disable code hoisting with -O3 or higher. */ + { OPT_LEVELS_3_PLUS, OPT_fcode_hoisting, NULL, 0 }, { OPT_LEVELS_NONE, 0, NULL, 0 } };