diff mbox series

[Ada,Darwin,PPC] PPC Darwin has stack check probes.

Message ID E0452F54-A2C9-43E9-B0D3-22821F489066@sandoe.co.uk
State New
Headers show
Series [Ada,Darwin,PPC] PPC Darwin has stack check probes. | expand

Commit Message

Iain Sandoe July 1, 2019, 7:25 p.m. UTC 
On PPC, Darwin uses the same code as other parts of the port, I suspect
that the False was a historical relic.

(perhaps I could have applied this with my Darwin maintainer’s hat, or as obvious,
 but wasn’t sure for the Ada sub-tree)

OK for trunk?
Thanks
Iain

2019-07-01  Iain Sandoe  <iain@sandoe.co.uk>

	* libgnat/system-darwin-ppc.ads: Set Stack_Check_Probes True for
	PPC Darwin.

Comments

Eric Botcazou July 1, 2019, 9:57 p.m. UTC | #1 
> 2019-07-01  Iain Sandoe  <iain@sandoe.co.uk>
> 
> 	* libgnat/system-darwin-ppc.ads: Set Stack_Check_Probes True for
> 	PPC Darwin.

OK, thanks.
Iain Sandoe Aug. 4, 2019, 9 a.m. UTC | #2 
> On 1 Jul 2019, at 22:57, Eric Botcazou <ebotcazou@adacore.com> wrote:
> 
>> 2019-07-01  Iain Sandoe  <iain@sandoe.co.uk>
>> 
>> 	* libgnat/system-darwin-ppc.ads: Set Stack_Check_Probes True for
>> 	PPC Darwin.
> 
> OK, thanks.

This (PPC)Darwin-specific patch has been on mainline for some time now 
without issues, the problem is present on open branches, may I backport it?

thanks
Iain
Eric Botcazou Aug. 4, 2019, 8:43 p.m. UTC | #3 
> This (PPC)Darwin-specific patch has been on mainline for some time now
> without issues, the problem is present on open branches, may I backport it?

Yes, thanks.
Iain Sandoe Aug. 5, 2019, 8:14 a.m. UTC | #4 
> On 4 Aug 2019, at 21:43, Eric Botcazou <ebotcazou@adacore.com> wrote:
> 
>> This (PPC)Darwin-specific patch has been on mainline for some time now
>> without issues, the problem is present on open branches, may I backport it?
> 
> Yes, thanks.

Done for 9.2
Iain
diff mbox series

Patch

diff --git a/gcc/ada/libgnat/system-darwin-ppc.ads b/gcc/ada/libgnat/system-darwin-ppc.ads
index d314b66..9adc2de 100644
--- a/gcc/ada/libgnat/system-darwin-ppc.ads
+++ b/gcc/ada/libgnat/system-darwin-ppc.ads
@@ -158,7 +158,7 @@  private
    Preallocated_Stacks       : constant Boolean := False;
    Signed_Zeros              : constant Boolean := True;
    Stack_Check_Default       : constant Boolean := False;
-   Stack_Check_Probes        : constant Boolean := False;
+   Stack_Check_Probes        : constant Boolean := True;
    Stack_Check_Limits        : constant Boolean := False;
    Support_Aggregates        : constant Boolean := True;
    Support_Atomic_Primitives : constant Boolean := Word_Size = 64;