From patchwork Mon May 6 07:39:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kong, Lingling" X-Patchwork-Id: 1931725 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=EoJoFo2D; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VXtbm3y2jz1ymb for ; Mon, 6 May 2024 17:40:04 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 88B8F3858C3A for ; Mon, 6 May 2024 07:40:02 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by sourceware.org (Postfix) with ESMTPS id D66193858D1E for ; Mon, 6 May 2024 07:39:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D66193858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D66193858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=192.198.163.12 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714981185; cv=pass; b=Wv0kvS5bxTkQ9GGrhgm0benM3ZY01SWLHdIZVs9S7dHjSqrXQnXLfPv/Gn1COE8nqEw07w+SZWn2vIg5mHlkRcU0WFU+ONoOULnykSsekdDmkbz4790aj1/aSkAGzwm/2hQqVI6ZuyZ/Ienqw5yejNRkhRl5nniuBxsuZQ2yLUk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714981185; c=relaxed/simple; bh=EjNbjmhRk70gKyc7dTfoy17S6bPwDunVMqdD7vtD36o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=h2cgaT/3j1lZ2qMoSRwzzObP2VvzUrlALQ71Ov0iU3wkHQ129Cf9GFdAEJfZIY70kus4/gPhlDMEgCVZllqOfAUGcvurbo5VjbtdbbZOKoP227hUZMs9+UYlBMiJow5yWSGsUVEBoAneMJwwICMwMDutR0A5BvpWKqBUxbqcOI8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714981183; x=1746517183; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EjNbjmhRk70gKyc7dTfoy17S6bPwDunVMqdD7vtD36o=; b=EoJoFo2DyZ5/3857Z835Djkz1DqAgo5lve/aZ7nrAHKrbw3KXCjjbGZd lfjrMlbanWwzUJxP6GUmM3Ak645UWgShjFwN5lQNA9RkqYC9433/rpQ0G RfkSRmD+rElZWR+9cYpj+IJXGBexlgeIsxC61To65YThBxVSizHowP2Ud THmtG6DoRAqggp+Pv03ZrFbKcVP4e+ICwqQScoBsA26QIPxUxK+Z4UNM7 9krJN6CN4AuHQn4dSjdohR0kKO4rsGQQsVPK8XBaQiGIoQby5tAx5n3tv 53hHqomV3B7pij4v9FIYvMnn9cnzsMXrk8e9np+/K7x3HJlRR/qrTDxJK w==; X-CSE-ConnectionGUID: HPyWSNnuRsyKUKyOQKyLoQ== X-CSE-MsgGUID: iq/oFCXCSR+cWzNMDb/l7A== X-IronPort-AV: E=McAfee;i="6600,9927,11064"; a="14520433" X-IronPort-AV: E=Sophos;i="6.07,257,1708416000"; d="scan'208";a="14520433" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 00:39:42 -0700 X-CSE-ConnectionGUID: Ad3UihGFTwy1+mhxzWNPxA== X-CSE-MsgGUID: e4MYah3wQLm8UN+1il5+Iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,257,1708416000"; d="scan'208";a="28193225" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 May 2024 00:39:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 6 May 2024 00:39:41 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 6 May 2024 00:39:41 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 6 May 2024 00:39:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2RqAVmVnqClEKiTIuAvSgyoJLGBOqd2MmpUYaaA7nJ3mfWxUEkeM5wZqas2BtOP4oqesrKhi83Dmgqf3jsatjBsyCALjG8sgIIxYmF3rhIjCIbDN0lfxh0U1umjZudq+I/2i3FRyM25HB0kXLzKo5forEX3Y5UIQHguyEcikwQLLDPU/GSoCZtq/aa2P3PUReiGoZcxpfahfmYUWIbdUkih3pBhsJSiaj/dySm0m8knWJ9A2DNa6rgeOJLSDCAVHpPneqatbui1j67VgiGfsStIvFrByRt2WPzCGocMNN1otuHamij2+4BHyR1Pq84mXNQv94sSx//QnR0Z3VjWAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=54aasYiMDiKzerSpA/fwzyS7nWuKcdV3SREI0qmqwQk=; b=AZth3tkZsdEZbRnLQpJkhlWJyoljWRIaVrlRHwH37SlQz6RXjqnuqHO5K8O8Gl4ILy3s+ArXJkt3Txsr7o9DrWPkHM/z7cKtwyVFSEyY8F5wJO6SWYd7Qtb3TW18vYiwCyj6nBpqz7jLcyGg0WfaLGMC/i/6haMHLfvbr+DckmzXoPSg9lW3clZOKXsyAnu8LzMrcYm3LBzjijPWPFnPaotinVN7LTLPmyKXDhHloK/DTRKyR+j4Lj8RKnruZZIPsVIZJH9maZ+0uQ1sHsYEayNh1gOmS7OisDkAVvVJimNFiTMBfKo/ENAwNuP8PV4NrhEeAqyIMowRisaeoGOlvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5487.namprd11.prod.outlook.com (2603:10b6:5:39f::22) by DM4PR11MB6067.namprd11.prod.outlook.com (2603:10b6:8:63::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May 2024 07:39:39 +0000 Received: from DM4PR11MB5487.namprd11.prod.outlook.com ([fe80::78e0:97cc:7662:7c96]) by DM4PR11MB5487.namprd11.prod.outlook.com ([fe80::78e0:97cc:7662:7c96%6]) with mapi id 15.20.7544.041; Mon, 6 May 2024 07:39:39 +0000 From: "Kong, Lingling" To: "gcc-patches@gcc.gnu.org" CC: "Liu, Hongtao" , Uros Bizjak Subject: [PATCH] i386: fix ix86_hardreg_mov_ok with lra_in_progress Thread-Topic: [PATCH] i386: fix ix86_hardreg_mov_ok with lra_in_progress Thread-Index: AQHan4VDRC+maSqQqEaClvZTvP2OD7GJy6EA Date: Mon, 6 May 2024 07:39:39 +0000 Message-ID: References: <20240506071557.2072799-1-lingling.kong@intel.com> In-Reply-To: <20240506071557.2072799-1-lingling.kong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5487:EE_|DM4PR11MB6067:EE_ x-ms-office365-filtering-correlation-id: c6c60442-3c66-4bd9-a9eb-08dc6d9fafcf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: nWrFsLSxWLhEJ06VdVoqY3ZQogIwfjBFa0BO8hlIyA1O5jE5CjTkcrVyTOJEVfjHKwHj2sfoKs3TEcfEtb99U4NsgQxplAkMrcb1K8TdANVKmlnsjoAXErsSckt51u5ARS7c+/o1M8O5slBty85tnxRyZJobpz0RZyRCKtWN7pWcR3xZimIiTk4oIndC4uezvVLfulqm1vN08PwWnjaBYQhJAs9ID6dTEJ9veaC3BnLzKaFD418KOgIgrdQCs90f6DIuNeS+BBkBimKF3D4ZForl5Ytd9R/rNx6mgONA13peIilfNJ+MksSFskHIjZAvloo57ixZ5HQd2ef+/+Mvg3GUO+r9EoicIIysiBLkycdg/JMjzanzgi+flsh4DmTAc8LyFRR/hhvi+P9OhDLR+ZcXNER4/H7SLVGz9LkD3fI5y/NsXdZYwy/I5VWsq3JxZJNChH9Cst+lguj3fNrjZV4drXTjyeJUKB52rICRtu1WWcTrhZEWwdHHPsOs3DhVFT9KsgepSILFAad04Gj6imE+yxL6QkyIbYNgv0nxiT6JOWUb6ccJz/6RmS9Gm3UxDQbXQGxTo9hIcnN2MrarlvRbGPHoS21YAgKX+QLVmhQKjwseoQ8uXvDmHkryJzha2D7eaCE6IvBwFxtRgnhr5mb8lpgnR5ojfPQffalrP/qYgZJrBGGmtIpPhninHAV66xQ7m9opPZiX2TMwHbLWQQcbQRNvLK3keFCQo5damdiLuQG+yGhy6bUdE3LtqEEERImYlYf4U/UIeP8LHt2KZnkbRV0A/wqDU28Rxl2xvR7jLFKT9ekieaQPvPHlOnIXkkGz2mi3rm7a4AIAt6b3wZE62B33K3bOQOhC/q5ENwTahudmPr88vFD0Oe2urx0ZASXAkwSXvj+g12c0ukUL/Q+PzjeOyEWbFpudmKV5fYy/22MPGEhw9jNVLlQpozsTGhKveBG5Gmt+zR2BS3QFWiV9oohfsGe6+fXJE0WpOVk9zF2nNiOoNohVFqlwEa8C7N20x2rVJr1rDPkG9qNROiPKcbwmgpyOBtip0k+EGEsEs51TFBfPCBXSwEsihfSAggfOJf6wCaXaOVOb002+iUfcECt2LVu6DheKvQEskhJwY5n5Q8VV8RR130/HYTnm37LdMPARKfXhr9KTRiWLpxI47l4WZ1fDcTtudSfE+zdg8gsk205nng1fGtBa67rCCHb1pVExZS++p0r4Vfr1uFxTuxMQzEFUA8+prQJ/622z0g9iIZqI2YMfo4OGQ1bQOQcaOokQN7PE/ZAvsSFVO6W2NXBX8EIvG/xSRWaxxlCuplo4pca/k/72NRkE+/5z9lnAsg9YxkWHYFrfLpUQ1w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: +kfwM477Fy3TMg3yS7xu3BiOy66o3Yc17A1Cx27H2UZzvFYdN5c+0euBms8VjfDJHEbzKRdlNc78a6pJ+yWF3MnSNMf9JpChoUOdkdLciINyZnKN9mkXFRMU1IS+IBnbYwt5FhQdXvC0TpJcQ9VZ8khPrkIlSpPIKPN7EXqc5mtwUcXV4KryKBujlvsI0B7XdVdbtTYhYzBV+j4K07TrI+hbelEIE+Q9VlLOQ91GMSJSSpY51XNquSzjIbnTtMN4ilqWvTCnlWttgp3ZBBEAns1A5qZtwmtpfWqpUfmx+l807jrMuUfrgIsBHN8KMnq07qjEJ0m1Ecr6VKwmgxBefWskJm3dsrsUwjRsTmRL9duxYxuSuU7b7Q50n6LOPgCOp9U7BIHCbRenQWMUpCeTs6ciBxCk3XNxIlhCh6pGAJ1tNmm3NiMgOVthWxZoPb3x4fPY3ab1zGQ2Rse2BM1Wec91Bv2qXiqcY+Pwrlf0i7mOIi/SpblhMfuPDQmx505FAvSOiHIFlnsy+pdSd3Ao6dOfW930Kn7kEeTCKLDAgwDinj7N5i3Hv1zZOuPsLT23sv8P2MARRG5QhuZrlYGKEZpAdtqcfGrG2/mfiXlgLLr9Hf0nifK6JpCftx1ZC7KO3s6Pm8CgPEWeiq/K3vgI4CktpS0ob3IinWrHM9zcil+FIQMrys+vcWgbKD0q1VGzGDtvK270WNyOgu/e2XA6hwWcUESSmR8iErf7lNNykTY5HiM5KVmzar2E4bYy8nwU9WYn5Tuf+mVMwDvZJ7CajyicLwvU/Hm0u0LL68kSogMVH0/wxcLClgJOXBTcFzGWTYRbAH+pD5PAnfKG3+4UfeUlLtWLEzzwgig9EnGgWxoFlLvVStOpUtMEIQziGqXsCc73TW1XY9hrtBtY+h12u1SpoaY9k/GoTPKhHUXc5uJv/dMnG2+a1U+p8mp0KbbZoCuNtDdvMYVIYwDFyiG503vJnIzdklmnoxJTiwRSmnvpuem7FVWEDroQLZNaqeCXaGRXxzs/eGvqDd0MRoJJGrk9J/l7b2UW6E4AESLfpkqdCQsGDChllN5kdM9h3xGyN+at2r30DJXuBa17tFI6+LOjLgxD+L693C8Ly0kPgpMd3+U1VNrb2z9iaWGK4eTOC02zCic2ibkLjhPQuBV6HfdHfUbQFqHf/WtiAYouv7sd/jIqahTlQDx98jNNG8rgBPaJJ/UsGFjj8w8EBrTwq4EixZ/IOK08VCSUuX56gDDJeK/NxwTDqoJr934lpWDOIuvVcyii8fOYO6nRBSsr3t/Al7vUsBKCJvYPau63XnrGQwrJS3fZvA7/LKfmMjpznmUyqXYFje8kt6c2f0yRNmLvNcNMqNIgtEwxMQ8K85VjSo7mtWXt0MFr+fwq/zNP0K+71SosiEJ76c/YjOT29vUFcyQl0NQh2hQAZOWyEAtSfeetu8ADHnTchTuazKJ72DQ5FeVA8Cw7kp42N+9nohhFZzc8oKHgFW3qcbJXZTtGg+w40HB2bfECxe6frCfTOtZ8GH3HH7vjZJJrheBrNCM4NYMXu1fPj1paI0NURdUka/LggL9OXipH4jOgBSwe MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6c60442-3c66-4bd9-a9eb-08dc6d9fafcf X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2024 07:39:39.6233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4RbJ/O1GFPnh17TU5XM9+H3a4P99Ym6Gi5YSxC2o91cl9ne6RKj4z5fZVJtO+kcwxLOH/z8up74508U4myuQ+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6067 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, Originally eliminate_regs_in_insn will transform (parallel [ (set (reg:QI 130) (plus:QI (subreg:QI (reg:DI 19 frame) 0) (const_int 96))) (clobber (reg:CC 17 flag))]) {*addqi_1} to (set (reg:QI 130) (subreg:QI (reg:DI 19 frame) 0)) {*movqi_internal} when verify_changes. But with No Flags add, it transforms (set (reg:QI 5 di) (plus:QI (subreg:QI (reg:DI 19 frame) 0) (const_int 96))) {*addqi_1_nf} to (set (reg:QI 5 di) (subreg:QI (reg:DI 19 frame) 0)) {*addqi_1_nf}. there is no extra clobbers at the end, and its dest reg just is a hardreg. For ix86_hardreg_mov_ok, it returns false. So it fails to update insn and causes the ICE when transform to movqi_internal. But actually it is ok and safe for ix86_hardreg_mov_ok when lra_in_progress. And tested the spec2017, the performance was not affected. Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for trunk? gcc/ChangeLog: * config/i386/i386.cc (ix86_hardreg_mov_ok): Relax hard reg mov restriction when lra in progress. --- gcc/config/i386/i386.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.31.1 diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 4d6b2b98761..ca4348a18bf 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -20357,7 +20357,8 @@ ix86_hardreg_mov_ok (rtx dst, rtx src) ? standard_sse_constant_p (src, GET_MODE (dst)) : x86_64_immediate_operand (src, GET_MODE (dst))) && ix86_class_likely_spilled_p (REGNO_REG_CLASS (REGNO (dst))) - && !reload_completed) + && !reload_completed + && !lra_in_progress) return false; return true; }