From patchwork Fri Dec 10 10:02:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joel Hutton X-Patchwork-Id: 1566415 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=j6p4VtVH; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J9RMS0Y9hz9s3q for ; Fri, 10 Dec 2021 21:04:18 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3CE83857C4E for ; Fri, 10 Dec 2021 10:04:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3CE83857C4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1639130655; bh=S8djSObzp+fMBmDBlZo85KxKDe2fP6Cdy7dmbQufo9I=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=j6p4VtVHvc4ELaiu2W+IVP1oUQZTRAQ5UMZAPdjobPgK3I8smEPmSCkzEDKws+iif 1HrnlR8olcBRZ6+bNu9dImHKKxg9jqFJEQUyd5uDBMCS/l9fruQmPylpRC/6MP7o46 MGHOcXLVVS8Xe8biqdN7x3yhxjk/1GtqMerBwe98= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by sourceware.org (Postfix) with ESMTPS id 0A9903858D35 for ; Fri, 10 Dec 2021 10:03:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A9903858D35 Received: from AS9PR06CA0305.eurprd06.prod.outlook.com (2603:10a6:20b:45b::24) by DB6PR08MB2856.eurprd08.prod.outlook.com (2603:10a6:6:20::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec 2021 10:03:11 +0000 Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::56) by AS9PR06CA0305.outlook.office365.com (2603:10a6:20b:45b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14 via Frontend Transport; Fri, 10 Dec 2021 10:03:11 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 10:03:10 +0000 Received: ("Tessian outbound 1cd1a01725a6:v110"); Fri, 10 Dec 2021 10:03:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 358bd38d16310224 X-CR-MTA-TID: 64aa7808 Received: from e9665219f74e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C352C135-98EA-4DAE-A532-D9A8ED9A9D15.1; Fri, 10 Dec 2021 10:02:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9665219f74e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 10 Dec 2021 10:02:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wla65cXRXNjRyotpTXiQ6/e3GwzU3kam8iaVdiyhU6CDNVl4aE0smJyOsLmp/4Or5PTlyWb4RGYo+R8DI9Ii3+pIkdsFw961LNIQzHJmmzUKGEBLUZTeMw6h1DveM+E8U+GhpzSZDoJP7QYuydtLr7shrTbSoZB3WvjCjpMdOYWdTBWuYz894x2k+9iv6C2PyWTK+z+THpp4mvbzVHezi/wcy1SRiF8JMNuWjHcmw+lsl4WHmGXz/llrmJw7/FIBgLqJ1XW4t5VlVb1Lbfk7JUm5GjlLYyQg/0raeSfjhs4z7qFJqbxSFlI/arHJaotNhSUYnwe2TkvqFZ4IJR9LvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S8djSObzp+fMBmDBlZo85KxKDe2fP6Cdy7dmbQufo9I=; b=R6SuGxNXJS4BQQK1oATMI9EmJhJv0Nr4g7KKUl4qusK56t1S9vqFgzHoM3annGhdl/jvUN++Apn1lllpVhcZ8/W3Qbl2498eIXvL7p/bLG0A3fNNawFbbu1h0SRnzEe24ExbzkqThZbNf1nrBFN+pAfnrbkrWXq2Ce2i5lQ1M/Djzg1VxpEjpnrievv6xT9sy0bTTeXV8/ZXmJWTd8ozHIKIsTHUqUubmClMaIq6uMyCLZlKJAnqSziwXYNB4kH/LQJhIceX0TkZ+Blwbw0cabIiIu6Xk+TbGzKxLr61jSkCZfMNWR+7SuZOrjrk2O7OsLYAR6N5IKaa2LQLG5iYXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from DB9PR08MB6603.eurprd08.prod.outlook.com (2603:10a6:10:25a::5) by DB7PR08MB3387.eurprd08.prod.outlook.com (2603:10a6:10:45::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec 2021 10:02:50 +0000 Received: from DB9PR08MB6603.eurprd08.prod.outlook.com ([fe80::8c3b:83a3:cf1:7e7e]) by DB9PR08MB6603.eurprd08.prod.outlook.com ([fe80::8c3b:83a3:cf1:7e7e%5]) with mapi id 15.20.4778.013; Fri, 10 Dec 2021 10:02:50 +0000 To: GCC Patches Subject: pr103523: Check for PLUS/MINUS support Thread-Topic: pr103523: Check for PLUS/MINUS support Thread-Index: AQHX7azaLB1yfKEDj0+jEACp/3QRiw== Date: Fri, 10 Dec 2021 10:02:49 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes X-MS-TNEF-Correlator: suggested_attachment_session_id: 98f6f59f-358a-222c-5bef-c1b4c3122ad9 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e84cee7f-cdc1-4961-8d9e-08d9bbc4457b x-ms-traffictypediagnostic: DB7PR08MB3387:EE_|AM5EUR03FT058:EE_|DB6PR08MB2856:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: J+yw7B/xqAqvRTWQ2pkxhEkH6n2VFIxCUubg417DMSdFzD8qk5zJ1ozSiiJPW7ELFw0EkmbdpVQ7ZlWCPIT205VxbmVkTo4DcmXTZKxFxXT+EkdOfF20N/0kTYeUKp784iAfG/tKU/UCVU/a+n/zMXoWbXfJzHhuYLyEW83tbWboFNOBpIq0xk7qAddzrMDf+HRyt21FHQXPsJxSBohCidH4TcluRp9P7+w0plYqCLE9iBMMGy/dmjCAx8pyPye+dZ9i2jS4wku0+1/KQmcvYuSHCB6O3w9/m7KUleGX0zy7JzM3RNK5QUdQRC7mNkLPG61KNr/IoJbQOctWxs2CmFSC9TdSE8xx7r5E6qZ70hBeHZRgu5J+Ppv0dBxCX/W8Js5Bi2C/joDOvPUg0wRb099a69FzLTOBkmowD+jiMqbgDDPJKgwEzy7FagNkd/REFbbhE8L1egn7GkmOgWCzaoZxaNYrkL5cE1ALgPFAXzsT4OJ6puI9kdP1YqaEtTvmysJrOLDEGsD+dFNPSu8TQjNAEC4UD3Oy0sizH+1wbYyjtaVf4yefCqe8Gj/OrJr6Hg2DJxZHGTdVuowPrTU3+M/QtGuuBLeqG0szhskHTlraX47vSBhuDZTx4GGS9wUNlU56cFuRclR9LelhCdcaXXg7O/nWnsyXkGYczPz7GOjjMRkKlEz8d0uQZj65m4lDlcmpGqozOk2GCRl1nKrTUw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB6603.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(66556008)(66476007)(5660300002)(66446008)(99936003)(186003)(316002)(8676002)(38100700002)(54906003)(122000001)(508600001)(52536014)(66946007)(71200400001)(7696005)(33656002)(4326008)(6506007)(38070700005)(9686003)(8936002)(26005)(91956017)(55016003)(86362001)(76116006)(4744005)(2906002)(6916009); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3387 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7bf6d5b2-61a4-43dd-55c6-08d9bbc43969 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PpzxXy8t9MWWfLsL6Ob6B9gmfvco3mgX0X3u59iVCfNOj6LTYlVh0EofvR+9fnO6dvSEfyRZ0FKD+nxvCA7xfe+l7eR7gFKxC7oQnKyuJ6dNdEtd6W8cjcLFnoeRrXBByux25Rmer2g5zjGmnNTVyPEZ5JR2DRxA1p1mOWwM/QDJl2IS11qtEtEq/QoIgHQaba6MrR8y42krcjtZ7ZZ7YSF2YKemlX+A+CU6xLNbKoy+OK7ukvwzx5syLKWC7CAB8LFAngf7kHLP3VhuKS3KpzsFQ11G/1BGYWTPbGE5QuMndoPgA5dX/2oyme4pcCh/vbV5uih9b/KtkTMcbzY3mFMXbaBW9JcakoKzdigvaV7V25ACgDBQKgs5oEislJ0JceT+Nr6n0FPbBaO35gx8hRRUUV8cMeW9dOMkPzMKihqiT+JrBCBYaAidip18m2iQzoJVmmECfsf5xilEjH9LIPUVBUoIpc/sLmXirMOGm837UzOG5B7KU+tc2THQzlydjWCyWQVF/Kul7CU7v60DpH+vF1uMlZXYK3ZJZoHuBURYdB4IBJCNhd/420e3gYLRMr06s9ZXJiiA92BEsL2bmLUjJ3+vJdEU7GbVi2eKfL+sHvgxkKWX5qQiNf1MAzZbwXEtDGxPgUdYSjyQUVvFt+qxk32hIWQND0Xdw6JSpWE/fcYBAehJF638GgNyNotdof4uBv2W5agOFSFfp3HDZA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(235185007)(8676002)(5660300002)(508600001)(33656002)(6916009)(8936002)(36860700001)(2906002)(63350400001)(63370400001)(186003)(26005)(52536014)(336012)(356005)(54906003)(9686003)(55016003)(81166007)(82310400004)(6506007)(47076005)(107886003)(70586007)(70206006)(316002)(7696005)(99936003)(86362001)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 10:03:10.2875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e84cee7f-cdc1-4961-8d9e-08d9bbc4457b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2856 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Joel Hutton via Gcc-patches From: Joel Hutton Reply-To: Joel Hutton Cc: Richard Sandiford , Richard Biener Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi all, This is to address pr103523. bootstrapped and regression tested on aarch64. Check for PLUS_EXPR/MINUS_EXPR support in vectorizable_induction. PR103523 is an ICE on valid code: void d(float *a, float b, int c) {     float e;     for (; c; c--, e += b)       a[c] = e; } This is due to not checking for PLUS_EXPR support, which is missing in VNx2sf mode. This causes an ICE at expand time. This patch adds a check for support in vectorizable_induction. gcc/ChangeLog:         PR tree-optimization/PR103523 * tree-vect-loop.c (vectorizable_induction): Check for     PLUS_EXPR/MINUS_EXPR support. diff --git a/gcc/testsuite/gcc.target/aarch64/pr103523.c b/gcc/testsuite/gcc.target/aarch64/pr103523.c new file mode 100644 index 0000000000000000000000000000000000000000..736e8936c5f6768bdf098ddc37b2c21ab74ee0df --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/pr103523.c @@ -0,0 +1,8 @@ +/* { dg-do compile } */ +/* { dg-options "-march=armv8-a+sve -mtune=neoverse-v1 -Ofast" } */ + +void d(float *a, float b, int c) { + float e; + for (; c; c--, e += b) + a[c] = e; +} diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 7f544ba1fd5198dd32cda05e62382ab2e1e9bb50..f700d5e7ac2c05402407a46113320f79359906fa 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -8065,6 +8065,15 @@ vectorizable_induction (loop_vec_info loop_vinfo, return false; } + step_expr = STMT_VINFO_LOOP_PHI_EVOLUTION_PART (stmt_info); + gcc_assert (step_expr != NULL_TREE); + tree step_vectype = get_same_sized_vectype (TREE_TYPE (step_expr), vectype); + + /* Check for backend support of PLUS/MINUS_EXPR. */ + if (!directly_supported_p (PLUS_EXPR, step_vectype) + || !directly_supported_p (MINUS_EXPR, step_vectype)) + return false; + if (!vec_stmt) /* transformation not required. */ { unsigned inside_cost = 0, prologue_cost = 0; @@ -8124,10 +8133,6 @@ vectorizable_induction (loop_vec_info loop_vinfo, if (dump_enabled_p ()) dump_printf_loc (MSG_NOTE, vect_location, "transform induction phi.\n"); - step_expr = STMT_VINFO_LOOP_PHI_EVOLUTION_PART (stmt_info); - gcc_assert (step_expr != NULL_TREE); - tree step_vectype = get_same_sized_vectype (TREE_TYPE (step_expr), vectype); - pe = loop_preheader_edge (iv_loop); /* Find the first insertion point in the BB. */ basic_block bb = gimple_bb (phi);