diff mbox

[2/3] Vectorize inductions that are live after the loop

Message ID D37AF255.FA28%alan.hayward@arm.com
State New
Headers show

Commit Message

Alan Hayward June 6, 2016, 9:03 a.m. UTC
On 03/06/2016 18:45, "Jakub Jelinek" <jakub@redhat.com> wrote:

>On Thu, Jun 02, 2016 at 05:11:15PM +0100, Alan Hayward wrote:
>> 	* gcc.dg/vect/vect-live-1.c: New test.
>> 	* gcc.dg/vect/vect-live-2.c: New test.
>> 	* gcc.dg/vect/vect-live-5.c: New test.
>> 	* gcc.dg/vect/vect-live-slp-1.c: New test.
>> 	* gcc.dg/vect/vect-live-slp-2.c: New test.
>> 	* gcc.dg/vect/vect-live-slp-3.c: New test.
>
>These tests all fail for me on i686-linux.  The problem is
>in the use of dg-options in gcc.dg/vect/, where it override all the
>various
>needed vectorization options that need to be enabled on various arches
>(e.g. -msse2 on i686).
>
>Fixed thusly, tested on x86_64-linux and i686-linux, ok for trunk?

Thanks for fixing this. However, I think you had a copy/paste error.
For vect-live-slp-1.c and vect-live-slp-3.c you used dg-options instead
of dg-additional-options, which causes the tests to fail for me as
UNRESOLVED.

Ok to commit?

Alan.


testsuite/
	* gcc.dg/vect/vect-live-1.c: Use additional-options.
	* gcc.dg/vect/vect-live-3.c: Likewise.

Comments

Jakub Jelinek June 6, 2016, 9:04 a.m. UTC | #1
On Mon, Jun 06, 2016 at 10:03:12AM +0100, Alan Hayward wrote:
> 
> On 03/06/2016 18:45, "Jakub Jelinek" <jakub@redhat.com> wrote:
> 
> >On Thu, Jun 02, 2016 at 05:11:15PM +0100, Alan Hayward wrote:
> >> 	* gcc.dg/vect/vect-live-1.c: New test.
> >> 	* gcc.dg/vect/vect-live-2.c: New test.
> >> 	* gcc.dg/vect/vect-live-5.c: New test.
> >> 	* gcc.dg/vect/vect-live-slp-1.c: New test.
> >> 	* gcc.dg/vect/vect-live-slp-2.c: New test.
> >> 	* gcc.dg/vect/vect-live-slp-3.c: New test.
> >
> >These tests all fail for me on i686-linux.  The problem is
> >in the use of dg-options in gcc.dg/vect/, where it override all the
> >various
> >needed vectorization options that need to be enabled on various arches
> >(e.g. -msse2 on i686).
> >
> >Fixed thusly, tested on x86_64-linux and i686-linux, ok for trunk?
> 
> Thanks for fixing this. However, I think you had a copy/paste error.
> For vect-live-slp-1.c and vect-live-slp-3.c you used dg-options instead
> of dg-additional-options, which causes the tests to fail for me as
> UNRESOLVED.
> 
> Ok to commit?

Oops.  Sure, thanks.

> testsuite/
> 	* gcc.dg/vect/vect-live-1.c: Use additional-options.
> 	* gcc.dg/vect/vect-live-3.c: Likewise.

	Jakub
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.dg/vect/vect-live-slp-1.c
b/gcc/testsuite/gcc.dg/vect/vect-live-slp-1.c
index 
82cd8dcabed8f18408e0e5cf295c2f15e0621ae6..7fefbff17d8c34bdfb1e8d697d2b9a70a
048ae16 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-live-slp-1.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-live-slp-1.c
@@ -1,5 +1,5 @@ 
 /* { dg-require-effective-target vect_int } */
-/* { dg-options "-fno-tree-scev-cprop" } */
+/* { dg-additional-options "-fno-tree-scev-cprop" } */

 #include "tree-vect.h"

diff --git a/gcc/testsuite/gcc.dg/vect/vect-live-slp-3.c
b/gcc/testsuite/gcc.dg/vect/vect-live-slp-3.c
index 
9e4a59eca593289050086b4b0a1347be5d748723..aacf5cb98071f6fec1f4b522eeefeb669
6787334 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-live-slp-3.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-live-slp-3.c
@@ -1,5 +1,5 @@ 
 /* { dg-require-effective-target vect_int } */
-/* { dg-options "-fno-tree-scev-cprop" } */
+/* { dg-additional-options "-fno-tree-scev-cprop" } */

 #include "tree-vect.h"