| Message ID | CY1PR1201MB1098D406F5A2DEE1256274F88FBB0@CY1PR1201MB1098.namprd12.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Mar 01, 2016 at 04:48:40PM +0000, Kumar, Venkataramanan wrote: > /* { dg-do compile } */ > -/* { dg-options "-Ofast -fdump-tree-ifcvt-details -fno-common -ftree-loop-if-convert-stores" } */ > +/* { dg-options "-Ofast -fdump-tree-ifcvt-details -ftree-loop-if-convert-stores" } */ > > #define LEN 4096 > - __attribute__((aligned (32))) float array[LEN]; > + __attribute__((visibility("hidden"), aligned (32))) float array[LEN] = {}; Don't you need /* { dg-require-visibility "" } */ if you use __attribute__ ((visibility))? Marek
On 03/01/2016 09:48 AM, Kumar, Venkataramanan wrote: > Hi Richard, > > As discussed in PR, tried to adjust the test case by initializing array, but looks like for building with -fpic it needs visibility to be set a hidden. > The below patch does that. > > > Ok for trunk ? > > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog > index 82e538e..f6bcb07 100644 > --- a/gcc/testsuite/ChangeLog > +++ b/gcc/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2016-03-01 Venkataramanan Kumar <Venkataramanan.kumar@amd.com> > + > + PR tree-optimization/68621 > + * gcc.dg/tree-ssa/ifc-8.c: Adjust test. OK. jeff
On Tue, Mar 1, 2016 at 5:48 PM, Kumar, Venkataramanan <Venkataramanan.Kumar@amd.com> wrote: > Hi Richard, > > As discussed in PR, tried to adjust the test case by initializing array, but looks like for building with -fpic it needs visibility to be set a hidden. > The below patch does that. Making the array 'static' would also work. Richard. > > Ok for trunk ? > > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog > index 82e538e..f6bcb07 100644 > --- a/gcc/testsuite/ChangeLog > +++ b/gcc/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2016-03-01 Venkataramanan Kumar <Venkataramanan.kumar@amd.com> > + > + PR tree-optimization/68621 > + * gcc.dg/tree-ssa/ifc-8.c: Adjust test. > + > 2016-02-29 Bill Schmidt <wschmidt@linux.vnet.ibm.com> > > PR target/70011 > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c b/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c > index 89a3410..7519a61 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c > @@ -1,9 +1,9 @@ > > /* { dg-do compile } */ > -/* { dg-options "-Ofast -fdump-tree-ifcvt-details -fno-common -ftree-loop-if-convert-stores" } */ > +/* { dg-options "-Ofast -fdump-tree-ifcvt-details -ftree-loop-if-convert-stores" } */ > > #define LEN 4096 > - __attribute__((aligned (32))) float array[LEN]; > + __attribute__((visibility("hidden"), aligned (32))) float array[LEN] = {}; > > void test () > {
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 82e538e..f6bcb07 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-03-01 Venkataramanan Kumar <Venkataramanan.kumar@amd.com> + + PR tree-optimization/68621 + * gcc.dg/tree-ssa/ifc-8.c: Adjust test. + 2016-02-29 Bill Schmidt <wschmidt@linux.vnet.ibm.com> PR target/70011 diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c b/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c index 89a3410..7519a61 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ifc-8.c @@ -1,9 +1,9 @@ /* { dg-do compile } */ -/* { dg-options "-Ofast -fdump-tree-ifcvt-details -fno-common -ftree-loop-if-convert-stores" } */ +/* { dg-options "-Ofast -fdump-tree-ifcvt-details -ftree-loop-if-convert-stores" } */ #define LEN 4096 - __attribute__((aligned (32))) float array[LEN]; + __attribute__((visibility("hidden"), aligned (32))) float array[LEN] = {}; void test () {