diff mbox

[AArch64] Enable AES and cmp_branch fusion for Thunderx2t99

Message ID CO2PR07MB2694E1D405D6FA1968F47C0A83740@CO2PR07MB2694.namprd07.prod.outlook.com
State New
Headers show

Commit Message

Hurugalawadi, Naveen Jan. 25, 2017, 6:16 a.m. UTC 
Hi,

Please find attached the patch that adds AES and CMP_BRANCH
fusion for Thunderx2t99.

Bootstrapped and Regression tested on aarch64-thunderx2t99.
Please review the patch and let us know if its okay?

2017-1-25  Naveen H.S <Naveen.Hurugalawadi@cavium.com>

gcc
        * config/aarch64/aarch64.c (thunderx2t99_tunings):
	Improve vector initialization code gen.

Thanks,
Naveen

Comments

Kyrill Tkachov Jan. 25, 2017, 9:21 a.m. UTC | #1 
Hi Naveen,

On 25/01/17 06:16, Hurugalawadi, Naveen wrote:
> Hi,
>
> Please find attached the patch that adds AES and CMP_BRANCH
> fusion for Thunderx2t99.
>
> Bootstrapped and Regression tested on aarch64-thunderx2t99.
> Please review the patch and let us know if its okay?

Code looks ok (it's quite simple), but I can't approve.
but there are a couple of issues with the ChangeLog

> 2017-1-25  Naveen H.S <Naveen.Hurugalawadi@cavium.com>

2017-01-25.
Also, two spaces between name and email

>
> gcc
>          * config/aarch64/aarch64.c (thunderx2t99_tunings):
> 	Improve vector initialization code gen.

This doesn't fit the code in the patch

Cheers,
Kyrill
Hurugalawadi, Naveen Feb. 2, 2017, 5:03 a.m. UTC | #2 
Hi Kyrill,

Thanks for the review and comments.

>> but there are a couple of issues with the ChangeLog

2017-02-02  Naveen H.S  <Naveen.Hurugalawadi@cavium.com>

	* config/aarch64/aarch64.c (thunderx2t99_tunings): Enable AES and
	cmp_branch fusion.

Thanks,
Naveen
James Greenhalgh Feb. 2, 2017, 11:42 a.m. UTC | #3 
On Thu, Feb 02, 2017 at 05:03:13AM +0000, Hurugalawadi, Naveen wrote:
> Hi Kyrill,
> 
> Thanks for the review and comments.
> 
> >> but there are a couple of issues with the ChangeLog
> 
> 2017-02-02  Naveen H.S  <Naveen.Hurugalawadi@cavium.com>
> 
> 	* config/aarch64/aarch64.c (thunderx2t99_tunings): Enable AES and
> 	cmp_branch fusion.
> 

OK.

Thanks,
James
diff mbox

Patch

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index f343d92..acaa975 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -780,7 +780,7 @@  static const struct tune_params thunderx2t99_tunings =
   &generic_approx_modes,
   4, /* memmov_cost.  */
   4, /* issue_rate.  */
-  AARCH64_FUSE_NOTHING, /* fuseable_ops.  */
+  (AARCH64_FUSE_CMP_BRANCH | AARCH64_FUSE_AES_AESMC), /* fusible_ops  */
   16,	/* function_align.  */
   8,	/* jump_align.  */
   16,	/* loop_align.  */