From patchwork Mon Mar 6 05:10:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hurugalawadi, Naveen" X-Patchwork-Id: 735527 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vc7GK4h0Tz9s2P for ; Mon, 6 Mar 2017 16:12:57 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="ebvQ+gs/"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; q=dns; s=default; b=ChH2rxNJbkUnKyKjSB0ReZ7gNJbCRj+9GRpgisJd4148j6QRGt 1Izc3OgVILnE+BGP5k2vL1hNSbK2178Vmq5fn7NJDh48wcFPx6W4IIDLihv9eBZ8 G2ztL386Jp265sfuz7Rr73OUdhE6BhvCBVyNi/gXH+iY34uV45rVE1xnM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; s= default; bh=KDjwspqpvbNqxceOvhsCoXMtbBw=; b=ebvQ+gs/2aACADLEjfrv cJKROGgdMgJUqPuJAcYZf9cMcsWRvaAVmPAMKq+uRxUIUEMpUsOE+bPd/f3m+A3I nYSu8EczvoVk8KOokk5sD+5XyhsrgkohYfDlXNUY7u1KjCFVgySauDP0zJNUTlN6 neBtEpHYf/xrgdPIKxdyc9I= Received: (qmail 118366 invoked by alias); 6 Mar 2017 05:11:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 117693 invoked by uid 89); 6 Mar 2017 05:11:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_WEB, SPF_HELO_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=H*c:HHH X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Received: from mail-co1nam03on0047.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) (104.47.40.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Mar 2017 05:11:08 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com (10.166.214.7) by CO2PR07MB2614.namprd07.prod.outlook.com (10.166.213.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Mon, 6 Mar 2017 05:10:11 +0000 Received: from CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) by CO2PR07MB2694.namprd07.prod.outlook.com ([10.166.214.7]) with mapi id 15.01.0947.018; Mon, 6 Mar 2017 05:10:10 +0000 From: "Hurugalawadi, Naveen" To: "gcc-patches@gcc.gnu.org" CC: "Pinski, Andrew" , James Greenhalgh , Marcus Shawcroft , Richard Earnshaw Subject: [PATCH][AArch64] Implement ALU_BRANCH fusion Date: Mon, 6 Mar 2017 05:10:10 +0000 Message-ID: authentication-results: cavium.com; dkim=none (message not signed) header.d=none; cavium.com; dmarc=none action=none header.from=cavium.com; x-microsoft-exchange-diagnostics: 1; CO2PR07MB2614; 7:1wPaxook2V3OSNEmpaHd4Yb7Ycca4kta+yYBR8OQXxDykLn+j3y1frfbMviQNdoHPWJA67LgpzN6BjqbpMAqBezKXkV/MjbXTf8j8JA2phv4HjRFAZoFVGxQhiUxkKjG58F7Xmbgvz8m72A7oz4BtcVkv5vDQfSaPIXn6alBq64R2h9jT3QHj4yxzHAHNUQxkHkIDJ5GBhjneBEt7iiHQ6RibJ6pBfajIAQNqKI7xuCt5EAzIWxvXGCGmCOrDxOwgT09uU0x+nitvzzpi25226S1OAgxX0H/ZHqwcMi/QhFH7oTVfOC6vtAVjgSN9sjVImRPZZlsehAh8Oc73bdA7w== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(377424004)(9686003)(55016002)(99286003)(5640700003)(8676002)(25786008)(6436002)(66066001)(6506006)(54906002)(81166006)(92566002)(305945005)(74316002)(7736002)(5660300001)(7696004)(6116002)(102836003)(3846002)(86362001)(99936001)(33656002)(122556002)(4326008)(189998001)(3280700002)(77096006)(2900100001)(2501003)(5890100001)(6916009)(8936002)(2351001)(2906002)(3660700001)(53936002)(110136004)(38730400002)(54356999)(50986999); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2614; H:CO2PR07MB2694.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-office365-filtering-correlation-id: 40603fe7-115e-4a13-ba44-08d4644f1067 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CO2PR07MB2614; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123558025)(20161123564025)(6072148); SRVR:CO2PR07MB2614; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2614; x-forefront-prvs: 0238AEEDB0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2017 05:10:10.5439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2614 Hi, Please find attached the patch that implements alu_branch fusion for AArch64. The patch doesn't change spec but improve other benchmarks. Bootstrapped and Regression tested on aarch64-thunder-linux. Please review the patch and let us know if its okay for Stage-1? Thanks, Naveen 2017-03-06 Julian Brown Naveen H.S * config/aarch64/aarch64-fusion-pairs.def: Add ALU_BRANCH entry. * config/aarch64/aarch64.c (AARCH64_FUSE_ALU_BRANCH): New fusion type. (thunderx2t99_tunings): Set AARCH64_FUSE_ALU_BRANCH flag. (aarch_macro_fusion_pair_p): Add support for AARCH64_FUSE_ALU_BRANCH. diff --git a/gcc/config/aarch64/aarch64-fusion-pairs.def b/gcc/config/aarch64/aarch64-fusion-pairs.def index f0e6dbc..300cd00 100644 --- a/gcc/config/aarch64/aarch64-fusion-pairs.def +++ b/gcc/config/aarch64/aarch64-fusion-pairs.def @@ -34,5 +34,6 @@ AARCH64_FUSION_PAIR ("movk+movk", MOVK_MOVK) AARCH64_FUSION_PAIR ("adrp+ldr", ADRP_LDR) AARCH64_FUSION_PAIR ("cmp+branch", CMP_BRANCH) AARCH64_FUSION_PAIR ("aes+aesmc", AES_AESMC) +AARCH64_FUSION_PAIR ("alu+branch", ALU_BRANCH) #undef AARCH64_FUSION_PAIR diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index fa25d43..62f5461 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -792,7 +792,8 @@ static const struct tune_params thunderx2t99_tunings = &generic_approx_modes, 4, /* memmov_cost. */ 4, /* issue_rate. */ - (AARCH64_FUSE_CMP_BRANCH | AARCH64_FUSE_AES_AESMC), /* fusible_ops */ + (AARCH64_FUSE_CMP_BRANCH | AARCH64_FUSE_AES_AESMC + | AARCH64_FUSE_ALU_BRANCH), /* fusible_ops */ 16, /* function_align. */ 8, /* jump_align. */ 16, /* loop_align. */ @@ -14063,6 +14064,37 @@ aarch_macro_fusion_pair_p (rtx_insn *prev, rtx_insn *curr) return true; } + if (aarch64_fusion_enabled_p (AARCH64_FUSE_ALU_BRANCH) + && any_uncondjump_p (curr)) + { + /* These types correspond to the reservation "vulcan_alu_basic" for + Broadcom Vulcan: these are ALU operations that produce a single uop + during instruction decoding. */ + switch (get_attr_type (prev)) + { + case TYPE_ALU_IMM: + case TYPE_ALU_SREG: + case TYPE_ADC_REG: + case TYPE_ADC_IMM: + case TYPE_ADCS_REG: + case TYPE_ADCS_IMM: + case TYPE_LOGIC_REG: + case TYPE_LOGIC_IMM: + case TYPE_CSEL: + case TYPE_ADR: + case TYPE_MOV_IMM: + case TYPE_SHIFT_REG: + case TYPE_SHIFT_IMM: + case TYPE_BFM: + case TYPE_RBIT: + case TYPE_REV: + case TYPE_EXTEND: + return true; + + default:; + } + } + return false; }